TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 104 Pull requests 17 Projects Releases 2 Activity Actions

blobovniczatree: Return source error from Init() #1630

Merged
fyrchik merged 1 commit from dstepanov-yadro/frostfs-node:fix/blobovniczatree_init_error into master 2025-02-04 07:13:47 +00:00
Conversation 1 Commits 1 Files changed 2 +60 -27
dstepanov-yadro commented 2025-02-03 14:42:43 +00:00
Member
Copy link

As it was before: when the database was opened, an error returned,
but along with the original error, the context cancelled error returned,
because iterateIncompletedRebuildDBPaths method has ctx.Done() check
and egCtx passed to iterateIncompletedRebuildDBPaths method.

Closes #1624

As it was before: when the database was opened, an error returned, but along with the original error, the `context cancelled` error returned, because `iterateIncompletedRebuildDBPaths` method has `ctx.Done()` check and egCtx passed to `iterateIncompletedRebuildDBPaths` method. Closes #1624
dstepanov-yadro added 1 commit 2025-02-03 14:42:44 +00:00
[#1624] blobovniczatree: Return source error from Init()
All checks were successful
DCO action / DCO (pull_request) Successful in 39s
Details
Vulncheck / Vulncheck (pull_request) Successful in 54s
Details
Build / Build Components (pull_request) Successful in 1m23s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 1m24s
Details
Tests and linters / Run gofumpt (pull_request) Successful in 1m32s
Details
Tests and linters / Staticcheck (pull_request) Successful in 1m56s
Details
Tests and linters / Tests (pull_request) Successful in 2m28s
Details
Tests and linters / Lint (pull_request) Successful in 2m38s
Details
Tests and linters / Tests with -race (pull_request) Successful in 3m47s
Details
Tests and linters / gopls check (pull_request) Successful in 3m49s
Details
Vulncheck / Vulncheck (push) Successful in 1m7s
Details
Pre-commit hooks / Pre-commit (push) Successful in 1m28s
Details
Tests and linters / Run gofumpt (push) Successful in 1m42s
Details
Build / Build Components (push) Successful in 2m9s
Details
Tests and linters / Staticcheck (push) Successful in 2m16s
Details
Tests and linters / Tests (push) Successful in 2m32s
Details
Tests and linters / Lint (push) Successful in 3m6s
Details
Tests and linters / Tests with -race (push) Successful in 3m36s
Details
Tests and linters / gopls check (push) Successful in 3m47s
Details
OCI image / Build container images (push) Successful in 4m28s
Details
4de5fca547 
As it was before: when the database was opened, an error returned,
but along with the original error, the `context cancelled`` error returned,
because `iterateIncompletedRebuildDBPaths` method has `ctx.Done()` check
and egCtx passed to `iterateIncompletedRebuildDBPaths` method.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
requested reviews from storage-core-committers, storage-core-developers 2025-02-03 14:42:44 +00:00
dstepanov-yadro reviewed 2025-02-03 14:43:24 +00:00
pkg/local_object_storage/blobstor/blobovniczatree/control.go
@ -68,3 +44,1 @@
if err != nil {
_ = eg.Wait()
return err
if b.blzInitWorkerCount > 0 {
dstepanov-yadro commented 2025-02-03 14:43:24 +00:00
Author
Member
Copy link

blzInitWorkerCount could be -1 (means no limit)

`blzInitWorkerCount` could be -1 (means no limit)
acid-ant approved these changes 2025-02-04 06:00:42 +00:00
acid-ant commented 2025-02-04 06:01:37 +00:00
Member
Copy link

Please remove redundant ` from commit message.

Please remove redundant ` from commit message.
fyrchik approved these changes 2025-02-04 07:13:42 +00:00
fyrchik merged commit 4de5fca547 into master 2025-02-04 07:13:47 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
acid-ant
fyrchik
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1630
No description provided.
Delete branch "dstepanov-yadro/frostfs-node:fix/blobovniczatree_init_error"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?