TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 105 Pull requests 11 Projects Releases 2 Activity Actions

engine: Fix data race in evacuation tests #1657

Merged
fyrchik merged 1 commit from dstepanov-yadro/frostfs-node:fix/evac_test_race into master 2025-02-28 14:14:15 +00:00
Conversation 0 Commits 1 Files changed 1 +1 -1
dstepanov-yadro commented 2025-02-28 11:53:00 +00:00
Member
Copy link
==================
WARNING: DATA RACE
Write at 0x00c00062a070 by goroutine 481:
  git.frostfs.info/TrueCloudLab/frostfs-node/pkg/local_object_storage/engine.TestEvacuateObjectsAsync()
      /workspace/TrueCloudLab/frostfs-node/pkg/local_object_storage/engine/evacuate_test.go:502 +0x1684
  testing.tRunner()
      /opt/hostedtoolcache/go/1.22.12/x64/src/testing/testing.go:1689 +0x21e
  testing.(*T).Run.gowrap1()
      /opt/hostedtoolcache/go/1.22.12/x64/src/testing/testing.go:1742 +0x44
      
Previous write at 0x00c00062a070 by goroutine 510:
  git.frostfs.info/TrueCloudLab/frostfs-node/pkg/local_object_storage/engine.TestEvacuateObjectsAsync.func3()
      /workspace/TrueCloudLab/frostfs-node/pkg/local_object_storage/engine/evacuate_test.go:478 +0x184
  golang.org/x/sync/errgroup.(*Group).Go.func1()
      /root/go/pkg/mod/golang.org/x/sync@v0.10.0/errgroup/errgroup.go:78 +0x91
``` ================== WARNING: DATA RACE Write at 0x00c00062a070 by goroutine 481: git.frostfs.info/TrueCloudLab/frostfs-node/pkg/local_object_storage/engine.TestEvacuateObjectsAsync() /workspace/TrueCloudLab/frostfs-node/pkg/local_object_storage/engine/evacuate_test.go:502 +0x1684 testing.tRunner() /opt/hostedtoolcache/go/1.22.12/x64/src/testing/testing.go:1689 +0x21e testing.(*T).Run.gowrap1() /opt/hostedtoolcache/go/1.22.12/x64/src/testing/testing.go:1742 +0x44 Previous write at 0x00c00062a070 by goroutine 510: git.frostfs.info/TrueCloudLab/frostfs-node/pkg/local_object_storage/engine.TestEvacuateObjectsAsync.func3() /workspace/TrueCloudLab/frostfs-node/pkg/local_object_storage/engine/evacuate_test.go:478 +0x184 golang.org/x/sync/errgroup.(*Group).Go.func1() /root/go/pkg/mod/golang.org/x/sync@v0.10.0/errgroup/errgroup.go:78 +0x91 ```
dstepanov-yadro added 1 commit 2025-02-28 11:53:00 +00:00
[#9999] engine: Fix data race in evacuation tests
All checks were successful
DCO action / DCO (pull_request) Successful in 43s
Details
Vulncheck / Vulncheck (pull_request) Successful in 1m14s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 1m36s
Details
Build / Build Components (pull_request) Successful in 1m30s
Details
Tests and linters / Staticcheck (pull_request) Successful in 3m6s
Details
Tests and linters / Run gofumpt (pull_request) Successful in 2m57s
Details
Tests and linters / Tests with -race (pull_request) Successful in 3m13s
Details
Tests and linters / Lint (pull_request) Successful in 3m20s
Details
Tests and linters / Tests (pull_request) Successful in 3m3s
Details
Tests and linters / gopls check (pull_request) Successful in 3m20s
Details
ce169db9e1 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
requested reviews from storage-core-committers, storage-core-developers 2025-02-28 11:53:01 +00:00
dstepanov-yadro force-pushed fix/evac_test_race from ce169db9e1 to f448babb99 2025-02-28 11:54:16 +00:00 Compare
fyrchik approved these changes 2025-02-28 13:05:36 +00:00
fyrchik merged commit 0991077cb3 into master 2025-02-28 14:14:15 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
fyrchik
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1657
No description provided.
Delete branch "dstepanov-yadro/frostfs-node:fix/evac_test_race"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?