Disable log sampling by default #1675
Labels
No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: TrueCloudLab/frostfs-node#1675
Loading…
Add table
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Console logger uses
zap
's production config:6d482535bd/config.go (L161)
. Production config defines, that zap will log only first 100 log entries for each level for 1 second. If there are more than 100 log entries in 1 second for level, then zap will log only 100-th log entries. For example, if there are 300 log entries for levelwarning
, then only 0...99, 100, 200, 300 log entries will be logged.Sampling hook only notifies if log entry was sampled or dropped.
Originally posted by @dstepanov-yadro in #1674 (comment)
Losing logs should not be the default behaviour.