TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 110 Pull requests 6 Projects Releases 2 Activity Actions

qos: Do not export zero metrics counters #1690

Merged
dstepanov-yadro merged 1 commit from dstepanov-yadro/frostfs-node:fix/qos_unknown_metric into master 2025-03-20 12:28:38 +00:00
Conversation 0 Commits 1 Files changed 1 +19 -6
dstepanov-yadro commented 2025-03-20 11:42:20 +00:00
Member
Copy link

No need to export zero counters

No need to export zero counters
dstepanov-yadro added 1 commit 2025-03-20 11:42:20 +00:00
[#9999] qos: Do not export zero metrics counters
All checks were successful
DCO action / DCO (pull_request) Successful in 33s
Details
Vulncheck / Vulncheck (pull_request) Successful in 1m3s
Details
Build / Build Components (pull_request) Successful in 2m3s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 2m8s
Details
Tests and linters / Run gofumpt (pull_request) Successful in 4m52s
Details
Tests and linters / Lint (pull_request) Successful in 5m28s
Details
Tests and linters / Tests with -race (pull_request) Successful in 5m38s
Details
Tests and linters / Staticcheck (pull_request) Successful in 5m35s
Details
Tests and linters / Tests (pull_request) Successful in 5m52s
Details
Tests and linters / gopls check (pull_request) Successful in 6m4s
Details
fd8670ddba 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
requested reviews from storage-core-committers, storage-core-developers 2025-03-20 11:42:21 +00:00
dstepanov-yadro force-pushed fix/qos_unknown_metric from fd8670ddba to af5b3575d0 2025-03-20 11:43:08 +00:00 Compare
acid-ant approved these changes 2025-03-20 11:44:47 +00:00
fyrchik approved these changes 2025-03-20 11:57:08 +00:00
internal/qos/limiter.go
@ -224,0 +228,4 @@
inProgress = s.inProgress.Load()
completed = s.completed.Load()
resExh = s.resourceExhausted.Load()
if pending == 0 && inProgress == 0 && completed == 0 && resExh == 0 {
fyrchik commented 2025-03-20 11:56:58 +00:00
Owner
Copy link

These counters only increase, so we don't need to consider case of removing metric on 1 -> 0 transition, right?

These counters only increase, so we don't need to consider case of removing metric on `1 -> 0` transition, right?
dstepanov-yadro commented 2025-03-20 12:28:05 +00:00
Author
Member
Copy link

right

right
dstepanov-yadro merged commit af5b3575d0 into master 2025-03-20 12:28:38 +00:00
dstepanov-yadro deleted branch fix/qos_unknown_metric 2025-03-20 12:28:41 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
acid-ant
fyrchik
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1690
No description provided.
Delete branch "dstepanov-yadro/frostfs-node:fix/qos_unknown_metric"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?