TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 109 Pull requests 5 Projects Releases 2 Activity Actions

metabase: Move cheaper conditions to the front in ListWithCursor() #1691

Merged
fyrchik merged 1 commit from fyrchik/frostfs-node:metabase-listwithcursor into master 2025-03-20 12:52:38 +00:00
Conversation 0 Commits 1 Files changed 1 +1 -1
fyrchik commented 2025-03-20 12:29:00 +00:00
Owner
Copy link

objectLocked call is expensive, it does IO. We may omit it if object
is not expired.

Signed-off-by: Evgenii Stratonikov e.stratonikov@yadro.com

`objectLocked` call is expensive, it does IO. We may omit it if object is not expired. Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
fyrchik added 1 commit 2025-03-20 12:29:00 +00:00
metabase: Move cheaper conditions to the front in ListWithCursor()
Some checks failed
DCO action / DCO (pull_request) Failing after 41s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 3m0s
Details
Vulncheck / Vulncheck (pull_request) Successful in 2m49s
Details
Build / Build Components (pull_request) Successful in 3m30s
Details
Tests and linters / Staticcheck (pull_request) Successful in 5m3s
Details
Tests and linters / gopls check (pull_request) Successful in 6m2s
Details
Tests and linters / Run gofumpt (pull_request) Successful in 6m21s
Details
Tests and linters / Lint (pull_request) Successful in 6m54s
Details
Tests and linters / Tests with -race (pull_request) Successful in 7m49s
Details
Tests and linters / Tests (pull_request) Successful in 7m54s
Details
8554214ff1 
`objectLocked` call is expensive, it does IO. We may omit it if object
is not expired.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
requested reviews from storage-core-committers, storage-core-developers 2025-03-20 12:29:01 +00:00
dstepanov-yadro approved these changes 2025-03-20 12:30:00 +00:00
fyrchik force-pushed metabase-listwithcursor from 8554214ff1 to 8a5bff3587 2025-03-20 12:30:11 +00:00 Compare
requested review from a-savchuk 2025-03-20 12:34:26 +00:00
acid-ant approved these changes 2025-03-20 12:36:58 +00:00
aarifullin approved these changes 2025-03-20 12:39:07 +00:00
fyrchik merged commit e8801dbf49 into master 2025-03-20 12:52:38 +00:00
fyrchik deleted branch metabase-listwithcursor 2025-03-20 12:52:52 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dstepanov-yadro
a-savchuk
acid-ant
aarifullin
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1691
No description provided.
Delete branch "fyrchik/frostfs-node:metabase-listwithcursor"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?