TrueCloudLab/frostfs-node

Fork 28

Make use of `internal/assert` package #1693

New issue

Open

opened 2025-03-21 04:54:12 +00:00 by fyrchik · 1 comment

fyrchik commented

2025-03-21 04:54:12 +00:00

Owner

There are a lot of explicit panics

$ rg panic | wc -l
182

Some of them (all of them?) may be replaced with assert.True.

There are a lot of explicit panics ``` $ rg panic | wc -l 182 ``` Some of them (all of them?) may be replaced with `assert.True`.

fyrchik added the

triage

label 2025-03-21 04:54:12 +00:00

fyrchik commented

2025-03-21 04:54:57 +00:00

Author

Owner

We may introduce assert.Truef(cond bool, fmt string, details any), if needed.

We may introduce `assert.Truef(cond bool, fmt string, details any)`, if needed.

fyrchik added the

discussion

refactoring

internal

labels 2025-03-21 04:55:13 +00:00

elebedeva self-assigned this 2025-04-01 11:11:36 +00:00

snegurochka referenced this issue from a commit

2025-04-08 11:59:59 +00:00

[#1693] internal/assert: Add `False` and `NoError` checks

snegurochka referenced this issue from a commit

2025-04-08 12:17:13 +00:00

[#1693] cli/adm: Replace conditional panics with asserts

snegurochka referenced this issue from a commit

2025-04-08 12:17:13 +00:00

[#1693] cli/lens: Replace conditional panics with asserts

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1693

No description provided.

Rows
Columns

Make use of internal/assert package #1693

Make use of `internal/assert` package #1693