TrueCloudLab/frostfs-node
20
1
Fork 28
Code Issues 114 Pull requests 4 Projects Releases 2 Activity Actions

WIP: Make Patch method patch split-header #1697

Closed
aarifullin wants to merge 3 commits from aarifullin/frostfs-node:fix/patch_split into support/v0.44
pull from: aarifullin/frostfs-node:fix/patch_split
merge into: TrueCloudLab:support/v0.44
Conversation 1 Commits 3 Files changed 5 +42 -4
aarifullin commented 2025-03-25 11:45:05 +00:00
Member
Copy link
  • Bump SDK version
  • Make patch streamer use PatchHeader
  • Add the option to frostfs-cli
* Bump SDK version * Make patch streamer use `PatchHeader` * Add the option to frostfs-cli
aarifullin added 3 commits 2025-03-25 11:45:06 +00:00 
Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
[#xx] cli: Add split-header option for object patch command
Some checks failed
DCO action / DCO (pull_request) Failing after 28s
Details
Tests and linters / Run gofumpt (pull_request) Successful in 44s
Details
Vulncheck / Vulncheck (pull_request) Successful in 1m2s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 1m44s
Details
Build / Build Components (pull_request) Successful in 1m47s
Details
Tests and linters / Tests (pull_request) Successful in 2m14s
Details
Tests and linters / Staticcheck (pull_request) Successful in 2m18s
Details
Tests and linters / gopls check (pull_request) Successful in 2m56s
Details
Tests and linters / Lint (pull_request) Successful in 3m8s
Details
Tests and linters / Tests with -race (pull_request) Successful in 4m24s
Details
2571ce87a4 
* Make `split-header` option read binary- or JSON-encoded split-header;
* Use `PatchHeader` instead of `PatchAttributes`

Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
requested reviews from storage-core-committers, storage-core-developers 2025-03-25 11:45:06 +00:00
aarifullin force-pushed fix/patch_split from 2571ce87a4 to 4b85757fd1 2025-03-25 12:10:51 +00:00 Compare
dstepanov-yadro requested changes 2025-03-25 15:22:44 +00:00
go.mod
@ -2,6 +2,8 @@ module git.frostfs.info/TrueCloudLab/frostfs-node
go 1.22
replace git.frostfs.info/TrueCloudLab/frostfs-sdk-go v0.0.0-20250204075528-d759a0980331 => git.frostfs.info/aarifullin/frostfs-sdk-go v0.0.0-20250324143057-e275ec3f8068
dstepanov-yadro commented 2025-03-25 15:22:35 +00:00
Member
Copy link

Fix

Fix
aarifullin changed title from Make Patch method patch split-header to WIP: Make Patch method patch split-header 2025-03-26 10:06:17 +00:00
fyrchik commented 2025-04-03 12:29:45 +00:00
Owner
Copy link

Merged in gerrit

Merged in gerrit
🚀 1
fyrchik closed this pull request 2025-04-03 12:29:46 +00:00
All checks were successful
DCO action / DCO (pull_request) Successful in 29s
Details
Vulncheck / Vulncheck (pull_request) Successful in 1m9s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 1m32s
Details
Build / Build Components (pull_request) Successful in 1m40s
Details
Tests and linters / Tests with -race (pull_request) Successful in 2m7s
Details
Tests and linters / Lint (pull_request) Successful in 2m31s
Details
Tests and linters / Run gofumpt (pull_request) Successful in 2m28s
Details
Tests and linters / Tests (pull_request) Successful in 2m39s
Details
Tests and linters / Staticcheck (pull_request) Successful in 2m38s
Details
Tests and linters / gopls check (pull_request) Successful in 3m23s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
dstepanov-yadro
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1697
No description provided.
Delete branch "aarifullin/frostfs-node:fix/patch_split"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?