TrueCloudLab/frostfs-node
20
1
Fork 28
Code Issues 113 Pull requests 3 Projects Releases 2 Activity Actions

Add maintenance zombie commands -> v0.38.6 #1698

Open
dstepanov-yadro wants to merge 3 commits from dstepanov-yadro/frostfs-node:zombie_v0386 into support/v0.38
pull from: dstepanov-yadro/frostfs-node:zombie_v0386
merge into: TrueCloudLab:support/v0.38
Conversation 0 Commits 3 Files changed 11 +1020
dstepanov-yadro commented 2025-03-27 12:54:23 +00:00
Member
Copy link
No description provided.
dstepanov-yadro added 1 commit 2025-03-27 12:54:24 +00:00
[#9999] adm: Add maintenance zombie commands
Some checks failed
DCO action / DCO (pull_request) Successful in 29s
Details
Vulncheck / Vulncheck (pull_request) Failing after 1m10s
Details
Tests and linters / Staticcheck (pull_request) Successful in 1m53s
Details
Tests and linters / Lint (pull_request) Failing after 2m4s
Details
Build / Build Components (pull_request) Successful in 2m31s
Details
Tests and linters / Tests (pull_request) Successful in 2m40s
Details
Tests and linters / Tests with -race (pull_request) Successful in 3m4s
Details
Tests and linters / gopls check (pull_request) Successful in 3m21s
Details
fc4e759ce5 
Change-Id: I2e85169849e2b9b7f44817b93283fa2f2b903676
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
dstepanov-yadro force-pushed zombie_v0386 from fc4e759ce5 to bb9b598042 2025-03-27 14:48:14 +00:00 Compare
dstepanov-yadro force-pushed zombie_v0386 from bb9b598042 to 1d646fce80 2025-03-27 14:59:49 +00:00 Compare
dstepanov-yadro force-pushed zombie_v0386 from 1d646fce80 to 08a374db1b 2025-03-27 15:02:01 +00:00 Compare
dstepanov-yadro force-pushed zombie_v0386 from 08a374db1b to 4cb32170f3 2025-03-28 08:11:24 +00:00 Compare
dstepanov-yadro changed title from WIP: Add maintenance zombie commands to Add maintenance zombie commands -> v.038.6 2025-03-28 08:17:46 +00:00
requested reviews from storage-core-committers, storage-core-developers 2025-03-28 08:17:46 +00:00
dstepanov-yadro changed title from Add maintenance zombie commands -> v.038.6 to Add maintenance zombie commands -> v0.38.6 2025-03-28 08:17:59 +00:00
dstepanov-yadro force-pushed zombie_v0386 from 4cb32170f3 to 6278986d62 2025-03-28 10:49:02 +00:00 Compare
acid-ant approved these changes 2025-03-28 13:22:40 +00:00
dstepanov-yadro added 1 commit 2025-03-31 09:27:44 +00:00
[#9999] adm: Add dry-run flag to zombie scan command
Some checks failed
DCO action / DCO (pull_request) Successful in 26s
Details
Tests and linters / Lint (pull_request) Failing after 1m38s
Details
Vulncheck / Vulncheck (pull_request) Failing after 1m35s
Details
Build / Build Components (pull_request) Successful in 2m5s
Details
Tests and linters / Staticcheck (pull_request) Successful in 2m57s
Details
Tests and linters / Tests with -race (pull_request) Successful in 3m13s
Details
Tests and linters / Tests (pull_request) Successful in 3m23s
Details
Tests and linters / gopls check (pull_request) Successful in 3m39s
Details
9ca7818fad 
This allows to just print object addresses that should be moved to quarantine.

Change-Id: I551979d8bffaf45fe21d92f6edadfaadcb5d6e25
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
dstepanov-yadro force-pushed zombie_v0386 from 9ca7818fad to 87c9e53c29 2025-03-31 09:46:30 +00:00 Compare
fyrchik reviewed 2025-03-31 11:13:58 +00:00
cmd/frostfs-adm/internal/modules/maintenance/zombie/scan.go Outdated
@ -0,0 +34,4 @@
if batchSize == 0 {
commonCmd.ExitOnErr(cmd, "invalid batch size: %w", errors.New("batch size must be positive value"))
}
dryRun, _ := cmd.Flags().GetBool(dryRunFlag)
fyrchik commented 2025-03-31 11:13:58 +00:00
Owner
Copy link

I believe, there should be an explicit desire to perform destructive changes.
How about asking for confirmation if --dry-run is omitted OR have --yes-i-want-to-really-move-data flag?

I believe, there should be an explicit desire to perform destructive changes. How about asking for confirmation if `--dry-run` is omitted OR have `--yes-i-want-to-really-move-data` flag?
dstepanov-yadro commented 2025-03-31 12:56:52 +00:00
Author
Member
Copy link

Good point. Replaced dry-run with move flag.

Good point. Replaced `dry-run` with `move` flag.
dstepanov-yadro force-pushed zombie_v0386 from 87c9e53c29 to 1a8acd0731 2025-03-31 11:23:27 +00:00 Compare
dstepanov-yadro force-pushed zombie_v0386 from 1a8acd0731 to e14a17be34 2025-03-31 11:24:42 +00:00 Compare
fyrchik approved these changes 2025-03-31 12:58:49 +00:00
dstepanov-yadro added 1 commit 2025-04-03 08:42:26 +00:00
[#9999] adm: Fix removed container case for zombie scan
Some checks failed
DCO action / DCO (pull_request) Successful in 27s
Details
Vulncheck / Vulncheck (pull_request) Failing after 1m18s
Details
Build / Build Components (pull_request) Successful in 1m29s
Details
Tests and linters / Tests (pull_request) Successful in 2m16s
Details
Tests and linters / Staticcheck (pull_request) Successful in 2m16s
Details
Tests and linters / Lint (pull_request) Successful in 2m29s
Details
Tests and linters / Tests with -race (pull_request) Successful in 3m4s
Details
Tests and linters / gopls check (pull_request) Successful in 3m37s
Details
358de18908 
Change-Id: I4452942b3dac87a3bd92421683745f183c300e22
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
Some checks failed
DCO action / DCO (pull_request) Successful in 27s
Details
Vulncheck / Vulncheck (pull_request) Failing after 1m18s
Details
Build / Build Components (pull_request) Successful in 1m29s
Details
Tests and linters / Tests (pull_request) Successful in 2m16s
Details
Tests and linters / Staticcheck (pull_request) Successful in 2m16s
Details
Tests and linters / Lint (pull_request) Successful in 2m29s
Details
Tests and linters / Tests with -race (pull_request) Successful in 3m4s
Details
Tests and linters / gopls check (pull_request) Successful in 3m37s
Details
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u zombie_v0386:dstepanov-yadro-zombie_v0386
git checkout dstepanov-yadro-zombie_v0386
Sign in to join this conversation.
Reviewers
No reviewers
acid-ant
fyrchik
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1698
No description provided.
Delete branch "dstepanov-yadro/frostfs-node:zombie_v0386"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?