TrueCloudLab/frostfs-node

Do not ignore errors by `metabase.Delete` #1704

New issue

Closed

opened 2025-04-03 06:56:38 +00:00 by dstepanov-yadro · 1 comment

dstepanov-yadro commented

2025-04-03 06:56:38 +00:00

Member

Now metabase ignores some errors for Delete without any motivation:

_ = bkt.Delete(item.key) // ignore error, best effort there

_ = bkt.Delete(item.key) // ignore error, best effort there

Errors should not be ignored.

Now metabase ignores some errors for `Delete` without any motivation: https://git.frostfs.info/TrueCloudLab/frostfs-node/src/commit/2a6cdbdb72a3acb07948bf1e0124df98fc964925/pkg/local_object_storage/metabase/delete.go#L382 https://git.frostfs.info/TrueCloudLab/frostfs-node/src/commit/2a6cdbdb72a3acb07948bf1e0124df98fc964925/pkg/local_object_storage/metabase/delete.go#L408 Errors should not be ignored.

dstepanov-yadro added the

good first issue

labels 2025-04-03 06:56:38 +00:00

dstepanov-yadro self-assigned this 2025-04-03 06:56:40 +00:00

snegurochka referenced this issue from a commit

2025-04-03 09:42:25 +00:00

[#1704] metabase: Do not ignore errors by Delete

dstepanov-yadro commented

2025-04-03 09:48:09 +00:00

Author

Member

Fixed

Fixed

dstepanov-yadro closed this issue

2025-04-03 09:48:10 +00:00

Sign in to join this conversation.

No labels

good first issue

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1704

No description provided.