tree: Pass tracing context in forEachNode #1707

Open
opened 2025-04-07 07:04:04 +00:00 by fyrchik · 0 comments
Owner

We create a span

ctx, span := tracing.StartSpanFromContext(ctx, "TreeService.IterateNetworkEndpoints",


But do not pass the context down

err := s.forEachNode(ctx, ns, func(c TreeServiceClient) bool {

Argument callback should accept context.

We create a span https://git.frostfs.info/TrueCloudLab/frostfs-node/src/commit/52367dc9b259b6044f0fc7fda09e4339b7170f3d/pkg/services/tree/redirect.go#L45 But do not pass the context down https://git.frostfs.info/TrueCloudLab/frostfs-node/src/commit/52367dc9b259b6044f0fc7fda09e4339b7170f3d/pkg/services/tree/redirect.go#L22 Argument callback should accept context.
fyrchik added the
bug
observability
internal
labels 2025-04-07 07:04:18 +00:00
fyrchik changed title from Pass tracing context in forEachNode to tree: Pass tracing context in forEachNode 2025-04-07 07:04:22 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1707
No description provided.