Remote `PUT` error won't propagate status code to client #1710

New issue

Closed

opened 2025-04-07 12:07:49 +00:00 by aarifullin · 1 comment

aarifullin commented

2025-04-07 12:07:49 +00:00

Member

Expected Behavior

A client (for instance, frostfs-cli) gets correct status code even the request is being processed on non-container node

Current Behavior

If the request is sent to non-container node and fails, client isn't able to parse an error status code

Possible Solution

Add Unwrap() to errIncompletePut
Make putStreamSigner sign response and set status even CloseAndRecv returns an error

Steps to Reproduce (for bugs)

Create REP 1 CBF 1 SELECT 1 container. Create ape-chain with allowing rules for this container;
Add local-override to container node with deny rule;
Try to put an object to this container requesting non-container node

Context

S3-GW is not able to correctly parse a status code and "sinks" it down to HTTP 500 status.

Regression

No regression

Your Environment

frostfs-dev-env

## Expected Behavior A client (for instance, `frostfs-cli`) gets correct status code even the request is being processed on **non**-container node ## Current Behavior If the request is sent to non-container node and fails, client isn't able to parse an error status code ## Possible Solution 1. Add `Unwrap()` to [errIncompletePut](https://git.frostfs.info/TrueCloudLab/frostfs-node/src/commit/2a6cdbdb72a3acb07948bf1e0124df98fc964925/pkg/services/object/common/writer/distributed.go#L84) 2. Make [putStreamSigner](https://git.frostfs.info/TrueCloudLab/frostfs-node/src/commit/2a6cdbdb72a3acb07948bf1e0124df98fc964925/pkg/services/object/sign.go#L92-L103) sign response and set status **even** `CloseAndRecv` returns an error ## Steps to Reproduce (for bugs)  1. Create `REP 1 CBF 1 SELECT 1` container. Create ape-chain with allowing rules for this container; 2. Add local-override to container node with `deny` rule; 3. Try to put an object to this container requesting **non-container** node ## Context S3-GW is not able to correctly parse a status code and "sinks" it down to HTTP 500 status. ## Regression No regression ## Your Environment `frostfs-dev-env`