TrueCloudLab/frostfs-node

Adopt `gocritic` linter #1718

New issue

Open

opened 2025-04-15 13:49:18 +00:00 by fyrchik · 0 comments

fyrchik commented

2025-04-15 13:49:18 +00:00

Owner

Specifically:

deferInLoop could've helped here https://review.frostfs.info/c/TrueCloudLab/frostfs-node/+/111, (thanks @acid-ant there)
deprecatedComment could've helped here TrueCloudLab/frostfs-sdk-go#353

deferInLoop is NOT a default, so it need to be enabled specifically.
I would start with disable-all and add checks incrementally after validating they are indeed useful.

Specifically: - `deferInLoop` could've helped here https://review.frostfs.info/c/TrueCloudLab/frostfs-node/+/111, (thanks @acid-ant there) - `deprecatedComment` could've helped here https://git.frostfs.info/TrueCloudLab/frostfs-sdk-go/pulls/353 `deferInLoop` is NOT a default, so it need to be enabled specifically. I would start with `disable-all` and add checks incrementally after validating they are indeed useful.

fyrchik added the

labels 2025-04-15 13:49:18 +00:00

dstepanov-yadro self-assigned this 2025-04-16 11:25:35 +00:00

snegurochka referenced this issue from a commit

2025-04-16 13:59:37 +00:00

[#1718] linter: Resolve gocritic's appendAssign linter

snegurochka referenced this issue from a commit

2025-04-16 13:59:37 +00:00

[#1718] linter: Resolve gocritic's unslice linter

snegurochka referenced this issue from a commit

2025-04-16 13:59:37 +00:00

[#1718] linter: Resolve gocritic's typeSwitchVar linter

snegurochka referenced this issue from a commit

2025-04-16 13:59:38 +00:00

[#1718] linter: Resolve gocritic's elseif linter

snegurochka referenced this issue from a commit

2025-04-16 13:59:38 +00:00

[#1718] linter: Resolve gocritic's singleCaseSwitch linter

snegurochka referenced this issue from a commit

2025-04-16 13:59:38 +00:00

[#1718] linter: Resolve gocritic's assignOp linter

snegurochka referenced this issue from a commit

2025-04-16 13:59:38 +00:00

[#1718] linter: Resolve gocritic's unlambda linter

snegurochka referenced this issue from a commit

2025-04-16 13:59:38 +00:00

[#1718] linter: Enable gocritic linter

Sign in to join this conversation.

No labels

good first issue

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1718

No description provided.