Resolve funlen linter #176

dstepanov-yadro · 2023-03-24T12:38:35Z

dstepanov-yadro commented

2023-03-24 12:38:35 +00:00

make linters great again

dstepanov-yadro force-pushed refactoring/fix_funlen from 450442373a to 57687d3cd4

2023-03-24 12:39:39 +00:00

Compare

dstepanov-yadro requested review from fyrchik 2023-03-24 12:39:56 +00:00

dstepanov-yadro requested review from carpawell 2023-03-24 12:40:05 +00:00

fyrchik approved these changes 2023-03-24 12:42:06 +00:00

pkg/morph/client/notifications.go Outdated

													
				@ -334,6 +304,42 @@ func (c *Client) restoreSubscriptions(cli *rpcclient.WSClient, endpoint string,

					return si, true

				}

				func (c *Client) startListen(stopCh <-chan struct{}, blockRcv <-chan *block.Block,

fyrchik commented

2023-03-24 12:42:03 +00:00

Why have you decided to perform go inside instead of go c.startListen()?

Why have you decided to perform `go` inside instead of `go c.startListen()`?

dstepanov-yadro commented

2023-03-24 12:42:57 +00:00

Poster

why not?

fyrchik commented

2023-03-24 16:12:15 +00:00

Because most of the function is indented 1 tab more to the right :)
Have nothing against, just wanted to hear reasoning.

Because most of the function is indented 1 tab more to the right :) Have nothing against, just wanted to hear reasoning.

👍 2

carpawell commented

2023-03-27 15:52:47 +00:00

i would also go @fyrchik's way

dstepanov-yadro requested review from storage-core-committers 2023-03-24 12:48:55 +00:00

dstepanov-yadro requested review from storage-core-developers 2023-03-24 12:48:55 +00:00

dstepanov-yadro force-pushed refactoring/fix_funlen from 57687d3cd4 to 91717d4b98

2023-03-27 15:50:24 +00:00

Compare

carpawell approved these changes 2023-03-27 15:52:55 +00:00

fyrchik merged commit 91717d4b98 into master

2023-03-27 15:54:49 +00:00

fyrchik referenced this issue from a commit

2023-03-27 15:54:50 +00:00

[#176] morph: Resolve funlen linter

Sign in to join this conversation.

No reviewers

TrueCloudLab/storage-core-developers

No Label

No Milestone

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#176