Make unit tests use require.NoError/t.Fatalf instead panic #180

New Issue

Closed

opened 2023-03-28 11:29:12 +00:00 by aarifullin · 1 comment

aarifullin commented

2023-03-28 11:29:12 +00:00

Collaborator

Some unit tests and test util functions throw panic if an error occured:

func testNewEngineWithShards(shards ...*shard.Shard) *StorageEngine {
	engine := New()

	for _, s := range shards {
		pool, err := ants.NewPool(10, ants.WithNonblocking(true))
		if err != nil {
			panic(err) // it's better to use require.NoError(t, err)
		}
    ...
}

The correct way to stop a test in the case of an error is to invoke require.NoError or t.Fatalf. The proposal is to replace all panic-s in unit tests by these package methods.

Some unit tests and test util functions throw `panic` if an error occured: ``` func testNewEngineWithShards(shards ...*shard.Shard) *StorageEngine { engine := New() for _, s := range shards { pool, err := ants.NewPool(10, ants.WithNonblocking(true)) if err != nil { panic(err) // it's better to use require.NoError(t, err) } ... } ``` The correct way to stop a test in the case of an error is to invoke `require.NoError` or `t.Fatalf`. The proposal is to replace all `panic`-s in unit tests by these package methods.