TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 100 Pull requests 6 Projects Releases 1 Activity Actions

Improvements here and there about notary deposits. #184

Merged
fyrchik merged 4 commits from carpawell/frostfs-node:fix/notary-deposit into master 2023-03-29 10:34:55 +00:00
Conversation 0 Commits 4 Files changed 6 +25 -11
carpawell commented 2023-03-28 16:06:54 +00:00
Contributor
Copy link

Fixes an infinite IR reload if IR is killed too soon after it started.

Fixes an infinite IR reload if IR is killed __too soon__ after it started.
carpawell self-assigned this 2023-03-28 16:07:02 +00:00
carpawell force-pushed fix/notary-deposit from 307bdd73b2 to a298333622 2023-03-28 16:07:47 +00:00 Compare
carpawell requested review from storage-core-committers 2023-03-28 16:08:08 +00:00
carpawell requested review from storage-core-developers 2023-03-28 16:08:08 +00:00
fyrchik approved these changes 2023-03-28 16:39:49 +00:00
pkg/innerring/notary.go Outdated
@ -108,3 +115,3 @@
}
func parseNotaryConfigs(cfg *viper.Viper, withSideNotary, withMainNotary bool) (main, side *notaryConfig) {
func parseNotaryConfigs(withSideNotary, withMainNotary bool) (main, side *notaryConfig) {
fyrchik commented 2023-03-28 16:36:22 +00:00
Owner
Copy link

Is it really parse after this?

Is it really `parse` after this?
carpawell commented 2023-03-29 07:30:36 +00:00
Author
Contributor
Copy link

dropped "parse" word, think it is the best thing that fits that PR

dropped "parse" word, think it is the best thing that fits that PR
fyrchik marked this conversation as resolved
pkg/morph/subscriber/subscriber.go Outdated
@ -138,6 +138,8 @@ func (s *subscriber) routeNotifications(ctx context.Context) {
zap.String("name", notifyEvent.Name),
)
fmt.Println("DEBUG: got notification")
fyrchik commented 2023-03-28 16:37:07 +00:00
Owner
Copy link

Wow!

Wow!
fyrchik commented 2023-03-28 16:38:02 +00:00
Owner
Copy link

If it is useful, maybe add a debug log before the switch? And remove one specific for notification events.

If it _is_ useful, maybe add a debug log before the switch? And remove one specific for notification events.
carpawell commented 2023-03-29 07:13:41 +00:00
Author
Contributor
Copy link

oh, nonono, not that necessary, artifact from another branch, fixed

oh, nonono, not that necessary, artifact from another branch, fixed
fyrchik marked this conversation as resolved
carpawell force-pushed fix/notary-deposit from a298333622 to 2136d8cdff 2023-03-29 07:11:59 +00:00 Compare
carpawell force-pushed fix/notary-deposit from 2136d8cdff to 7b360f449f 2023-03-29 07:22:58 +00:00 Compare
carpawell requested review from fyrchik 2023-03-29 07:40:32 +00:00
dstepanov-yadro approved these changes 2023-03-29 07:51:18 +00:00
fyrchik approved these changes 2023-03-29 10:34:45 +00:00
fyrchik merged commit e843e7f090 into master 2023-03-29 10:34:55 +00:00
fyrchik referenced this pull request from a commit 2023-03-29 10:34:55 +00:00
[#184] morph: Make deposit logs INFO
carpawell deleted branch fix/notary-deposit 2023-03-29 14:04:41 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dstepanov-yadro
fyrchik
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
carpawell
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#184
No description provided.
Delete branch "carpawell/frostfs-node:fix/notary-deposit"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?