Correctly process some logical errors #211

fyrchik · 2023-04-05T07:50:29Z

fyrchik commented

2023-04-05 07:50:29 +00:00

Directory creation can fail with ENOSPC, consider it logical.
If shard is in the degraded mode, there is no need to consult pilorama.

1. Directory creation can fail with ENOSPC, consider it logical. 2. If shard is in the degraded mode, there is no need to consult pilorama.

fyrchik force-pushed handle-logical-errors from 0ebdcdfe65 to 60057f1d68

2023-04-05 07:50:50 +00:00

Compare

dstepanov-yadro reviewed 2023-04-05 07:53:28 +00:00

pkg/local_object_storage/shard/tree.go Outdated

					
				@ -62,2 +71,4 @@

						return nil, ErrPiloramaDisabled

					}

					s.m.RLock()

dstepanov-yadro commented

2023-04-05 07:52:40 +00:00

lock will be held for pilorama.TreeGetByPath call. Is it ok?

Same for other calls.

lock will be held for ```pilorama.TreeGetByPath``` call. Is it ok? Same for other calls.

fyrchik commented

2023-04-05 08:04:49 +00:00

Yes, basically what we do here is to allow operations to finish before other, possibly disruptive, operations such as SetMode take place.

Yes, basically what we do here is to allow operations to finish before other, possibly disruptive, operations such as `SetMode` take place.

dstepanov-yadro marked this conversation as resolved

dstepanov-yadro approved these changes 2023-04-05 08:05:42 +00:00

acid-ant commented

2023-04-05 08:33:07 +00:00

Typo in commit message the shard it not

Typo in commit message `the shard it not`

👍 1

acid-ant approved these changes 2023-04-05 08:36:33 +00:00

fyrchik force-pushed handle-logical-errors from 60057f1d68 to 731979a482

2023-04-05 11:02:57 +00:00

Compare

fyrchik merged commit 9098d0eec0 into master

2023-04-05 11:10:40 +00:00

fyrchik deleted branch handle-logical-errors

2023-04-05 11:10:40 +00:00

fyrchik referenced this pull request from a commit

2023-04-05 11:10:41 +00:00

[#211] fstree: Consider ENOSPC a logical error

fyrchik referenced this pull request from a commit

2023-04-05 11:10:41 +00:00

[#211] engine: Unify shard mode checks for tree operations

fyrchik referenced this pull request

2023-04-05 13:04:37 +00:00

Unexpected increase error count when no space left on shard #216

Sign in to join this conversation.

No reviewers

No labels

No milestone

No project

No assignees

3 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#211