TrueCloudLab
/
frostfs-node
18
1
Fork 20
Code Issues 88 Pull Requests 7 Actions Releases Activity

Correctly process some logical errors #211

Merged
fyrchik merged 2 commits from fyrchik/frostfs-node:handle-logical-errors into master 2023-04-05 11:10:40 +00:00
Conversation 1 Commits 2 Files Changed 2
fyrchik commented 2023-04-05 07:50:29 +00:00
Owner
  1. Directory creation can fail with ENOSPC, consider it logical.
  2. If shard is in the degraded mode, there is no need to consult pilorama.
1. Directory creation can fail with ENOSPC, consider it logical. 2. If shard is in the degraded mode, there is no need to consult pilorama.
fyrchik force-pushed handle-logical-errors from 0ebdcdfe65 to 60057f1d68 2023-04-05 07:50:50 +00:00 Compare
dstepanov-yadro reviewed 2023-04-05 07:53:28 +00:00
pkg/local_object_storage/shard/tree.go Outdated
@ -62,2 +71,4 @@
return nil, ErrPiloramaDisabled
}
s.m.RLock()
dstepanov-yadro commented 2023-04-05 07:52:40 +00:00
Collaborator

lock will be held for pilorama.TreeGetByPath call. Is it ok?

Same for other calls.

lock will be held for ```pilorama.TreeGetByPath``` call. Is it ok? Same for other calls.
fyrchik commented 2023-04-05 08:04:49 +00:00
Poster
Owner

Yes, basically what we do here is to allow operations to finish before other, possibly disruptive, operations such as SetMode take place.

Yes, basically what we do here is to allow operations to finish before other, possibly disruptive, operations such as `SetMode` take place.
dstepanov-yadro marked this conversation as resolved
dstepanov-yadro approved these changes 2023-04-05 08:05:42 +00:00
acid-ant commented 2023-04-05 08:33:07 +00:00
Collaborator

Typo in commit message the shard it not

Typo in commit message `the shard it not`
👍 1
acid-ant approved these changes 2023-04-05 08:36:33 +00:00
fyrchik force-pushed handle-logical-errors from 60057f1d68 to 731979a482 2023-04-05 11:02:57 +00:00 Compare
fyrchik merged commit 9098d0eec0 into master 2023-04-05 11:10:40 +00:00
fyrchik deleted branch handle-logical-errors 2023-04-05 11:10:40 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dstepanov-yadro
acid-ant
Labels
Clear labels   
P0

Highest   
P1

High   
P2

Medium   
P3

Low   
badger

Badger DB related issues   
frostfs-adm
   
frostfs-cli
   
frostfs-ir
   
frostfs-lens
   
frostfs-node
   
good first issue

Good for newcomers   
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff   
blocked

The issue or PR is blocked by something   
bug

Something is not working   
config

Configuration format update or breaking change   
discussion

Talking about something in order to reach a decision or to exchange ideas   
documentation

Documentation related   
duplicate

This issue or pull request already exists   
enhancement

New feature   
go

Language features adoption   
help wanted

Extra attention is needed   
internal
   
invalid

Something is wrong   
kludge

This is a kludge and we know it   
observability

Related to metrics, tracing and logs   
perfomance

Perfomance related   
question

More information is needed   
refactoring

Refactoring   
wontfix

This won't be fixed
No Label
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#211
There is no content yet.
Delete Branch "fyrchik/frostfs-node:handle-logical-errors"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?