TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 109 Pull requests 11 Projects Releases 2 Activity Actions

Refactor reputation service #212

Merged
fyrchik merged 3 commits from dstepanov-yadro/frostfs-node:refactoring/object-3610-reputation into master 2023-04-07 15:35:58 +00:00
Conversation 0 Commits 3 Files changed 25 +267 -315
dstepanov-yadro commented 2023-04-05 08:49:30 +00:00
Member
Copy link

Resolve linters.
Rename context structs and interfaces to be understandable.

Resolve linters. Rename *context* structs and interfaces to be understandable.
dstepanov-yadro force-pushed refactoring/object-3610-reputation from c0b73dda74 to 65a07878a2 2023-04-05 08:51:19 +00:00 Compare
dstepanov-yadro changed title from WIP: Refactor reputation service to Refactor reputation service 2023-04-05 08:57:41 +00:00
requested reviews from storage-core-committers, storage-core-developers 2023-04-05 08:57:46 +00:00
aarifullin approved these changes 2023-04-05 14:06:35 +00:00
aarifullin left a comment
Member
Copy link

LGTM

LGTM
fyrchik reviewed 2023-04-05 15:02:49 +00:00
cmd/frostfs-node/reputation/common/util.go Outdated
@ -11,3 +10,1 @@
// nolint: containedctx
type EpochContext struct {
context.Context
// EpochProvider ...
fyrchik commented 2023-04-05 14:41:50 +00:00
Owner
Copy link

EpochProvider is a constant/dummy epoch source?

`EpochProvider is a constant/dummy epoch source`?
dstepanov-yadro commented 2023-04-06 06:10:17 +00:00
Author
Member
Copy link

yes

yes
fyrchik commented 2023-04-06 07:03:57 +00:00
Owner
Copy link

I mean what is ... comment for?

I mean what is `...` comment for?
dstepanov-yadro commented 2023-04-06 08:52:52 +00:00
Author
Member
Copy link

Lazy developer detected: it's me.
Followed this rule:

All top-level, exported names should have doc comments

(from https://github.com/golang/go/wiki/CodeReviewComments#doc-comments)

As I see it, we do not have such a rule. Deleted the comment.

Lazy developer detected: it's me. Followed this rule: > All top-level, exported names should have doc comments (from https://github.com/golang/go/wiki/CodeReviewComments#doc-comments) As I see it, we do not have such a rule. Deleted the comment.
fyrchik marked this conversation as resolved
cmd/frostfs-node/reputation/common/util.go Outdated
@ -15,3 +13,3 @@
}
func (ctx *EpochContext) Epoch() uint64 {
func (ctx *EpochProvider) Epoch() uint64 {
fyrchik commented 2023-04-05 14:40:34 +00:00
Owner
Copy link

It's no longer ctx, I guess?

It's no longer `ctx`, I guess?
dstepanov-yadro commented 2023-04-06 06:16:24 +00:00
Author
Member
Copy link

fixed

fixed
fyrchik marked this conversation as resolved
dstepanov-yadro force-pushed refactoring/object-3610-reputation from 65a07878a2 to 1bc3d79ddd 2023-04-06 06:16:06 +00:00 Compare
dstepanov-yadro force-pushed refactoring/object-3610-reputation from 1bc3d79ddd to fc4f4b7533 2023-04-06 08:41:32 +00:00 Compare
fyrchik approved these changes 2023-04-07 15:35:52 +00:00
fyrchik merged commit c236b54a65 into master 2023-04-07 15:35:58 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
aarifullin
fyrchik
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#212
No description provided.
Delete branch "dstepanov-yadro/frostfs-node:refactoring/object-3610-reputation"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?