TrueCloudLab/frostfs-node
21
1
Fork 27
Code Issues 108 Pull requests 3 Projects Releases 1 Activity Actions

Refactor morph #219

Merged
fyrchik merged 1 commit from dstepanov-yadro/frostfs-node:refactoring/object-3060-morph into master 2023-07-26 21:07:57 +00:00
Conversation 0 Commits 1 Files changed 1 +55 -48
dstepanov-yadro commented 2023-04-05 15:31:01 +00:00
Member
Copy link

Resolve linters

Resolve linters
dstepanov-yadro force-pushed refactoring/object-3060-morph from 4b994e64bc to a45503387d 2023-04-05 15:32:35 +00:00 Compare
dstepanov-yadro requested review from storage-core-committers 2023-04-06 06:06:08 +00:00
dstepanov-yadro requested review from storage-core-developers 2023-04-06 06:06:08 +00:00
dstepanov-yadro changed title from WIP: Refactor morph to Refactor morph 2023-04-06 06:06:13 +00:00
dstepanov-yadro force-pushed refactoring/object-3060-morph from a45503387d to e54d565049 2023-04-06 15:01:22 +00:00 Compare
aarifullin reviewed 2023-04-07 11:58:20 +00:00
pkg/morph/client/notary.go Outdated
@ -500,3 +529,3 @@
until, err = c.notaryTxValidationLimit()
if err != nil {
return err
return 0, err
aarifullin commented 2023-04-07 11:58:20 +00:00
Member
Copy link

[Optional]

Could this be simplified?

func (c *Client) getUntilValue(vub *uint32) (until uint32, err error) {
    if vub != nil {
       until = *vub
 	   return
    }
    until, err = c.notaryTxValidationLimit()
    return
}

or

func (c *Client) getUntilValue(vub *uint32) (uint32, error) {
    if vub != nil {
       return *vub, nil
    }
    return c.notaryTxValidationLimit()
}
[Optional] Could this be simplified? ``` func (c *Client) getUntilValue(vub *uint32) (until uint32, err error) { if vub != nil { until = *vub return } until, err = c.notaryTxValidationLimit() return } ``` or ``` func (c *Client) getUntilValue(vub *uint32) (uint32, error) { if vub != nil { return *vub, nil } return c.notaryTxValidationLimit() } ```
dstepanov-yadro commented 2023-04-07 12:43:59 +00:00
Author
Member
Copy link

Done.

Done.
dstepanov-yadro force-pushed refactoring/object-3060-morph from e54d565049 to fe87735073 2023-04-07 12:43:41 +00:00 Compare
aarifullin approved these changes 2023-04-07 13:09:34 +00:00
aarifullin left a comment
Member
Copy link

LGTM

LGTM
fyrchik approved these changes 2023-04-07 13:50:28 +00:00
pkg/morph/event/listener.go
@ -249,3 +246,1 @@
l.log.Warn("listener worker pool drained",
zap.Int("capacity", l.pool.Cap()))
}
l.handleNotifyEvent(notifyEvent)
fyrchik commented 2023-04-07 13:50:12 +00:00
Owner
Copy link

What about submiting here and processing error outside the switch?

What about submiting here and processing error outside the switch?
dstepanov-yadro commented 2023-04-07 14:10:28 +00:00
Author
Member
Copy link

Then funlen and gocognit linters will not pass:)

Then funlen and gocognit linters will not pass:)
fyrchik marked this conversation as resolved
acid-ant approved these changes 2023-04-07 13:59:07 +00:00
fyrchik merged commit fe87735073 into master 2023-04-07 14:27:43 +00:00
fyrchik referenced this pull request from a commit 2023-04-07 14:27:44 +00:00
[#219] morph: Refactor notary invoke
Sign in to join this conversation.
Reviewers
No reviewers
aarifullin
fyrchik
acid-ant
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#219
No description provided.
Delete branch "dstepanov-yadro/frostfs-node:refactoring/object-3060-morph"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?