TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 100 Pull requests 4 Projects Releases 1 Activity Actions

Refactorings #223

Merged
fyrchik merged 1 commit from dstepanov-yadro/frostfs-node:refactoring/object-3060-remain into master 2023-07-26 21:07:57 +00:00
Conversation 0 Commits 1 Files changed 1 +2 -2
dstepanov-yadro commented 2023-04-06 13:29:54 +00:00
Member
Copy link

Resolve linters

Resolve linters
dstepanov-yadro force-pushed refactoring/object-3060-remain from 8bb258de5b to 9e397d9b18 2023-04-06 13:32:02 +00:00 Compare
dstepanov-yadro changed title from WIP: Refactorings to Refactorings 2023-04-06 13:32:38 +00:00
dstepanov-yadro requested review from storage-core-committers 2023-04-06 13:32:45 +00:00
dstepanov-yadro requested review from storage-core-developers 2023-04-06 13:32:45 +00:00
dstepanov-yadro force-pushed refactoring/object-3060-remain from 9e397d9b18 to 3c4a4c3a38 2023-04-06 14:40:55 +00:00 Compare
ale64bit requested changes 2023-04-10 09:40:12 +00:00
pkg/core/object/fmt.go Outdated
@ -213,106 +211,124 @@ func (v *FormatValidator) ValidateContent(o *object.Object) (ContentMeta, error)
case object.TypeRegular:
ale64bit commented 2023-04-10 09:21:00 +00:00
Member
Copy link

remove this, since a default case was added?

remove this, since a `default` case was added?
dstepanov-yadro commented 2023-04-10 10:58:12 +00:00
Author
Member
Copy link

fixed

fixed
ale64bit marked this conversation as resolved
pkg/core/object/fmt.go Outdated
@ -216,2 +214,2 @@
if len(o.Payload()) == 0 {
return ContentMeta{}, fmt.Errorf("(%T) empty payload in tombstone", v)
if err := v.fillAndValidateTombstoneMeta(o, &meta); err != nil {
return ContentMeta{}, err
ale64bit commented 2023-04-10 09:24:33 +00:00
Member
Copy link

Maybe expand the error? fmt.Errorf("validating tombstone: %v", err)
Since the new fillAndValidateXXX functions do not always include info about the type. Same in the other cases below.

Maybe expand the error? `fmt.Errorf("validating tombstone: %v", err)` Since the new `fillAndValidateXXX` functions do not always include info about the type. Same in the other cases below.
dstepanov-yadro commented 2023-04-10 11:01:10 +00:00
Author
Member
Copy link

As I understood @fyrchik comment (#223 (comment)), there is no need to add new functionality, since this is refactoring.

As I understood @fyrchik comment (https://git.frostfs.info/TrueCloudLab/frostfs-node/pulls/223#issuecomment-5164), there is no need to add new functionality, since this is refactoring.
👍 1
ale64bit marked this conversation as resolved
pkg/core/object/fmt.go Outdated
@ -245,3 +237,1 @@
if len(o.Payload()) == 0 {
return ContentMeta{}, fmt.Errorf("(%T) empty payload in SG", v)
}
_, ok := o.ContainerID()
ale64bit commented 2023-04-10 09:32:09 +00:00
Member
Copy link

do we have some rule to not one-line these? (same below)

if _, ok := o.ContainerID(); !ok {
    (...)
}

this is not introduced by this PR, but seems to happen a lot in the codebase. Not sure what's the benefit of polluting the namespace when there's no need.

do we have some rule to not one-line these? (same below) ``` if _, ok := o.ContainerID(); !ok { (...) } ``` this is not introduced by this PR, but seems to happen a lot in the codebase. Not sure what's the benefit of polluting the namespace when there's no need.
dstepanov-yadro commented 2023-04-10 10:57:55 +00:00
Author
Member
Copy link

fixed

fixed
ale64bit marked this conversation as resolved
pkg/core/object/fmt.go Outdated
@ -279,2 +280,2 @@
return ContentMeta{}, errors.New("missing container")
}
if err := sg.Unmarshal(o.Payload()); err != nil {
return fmt.Errorf("(%T) could not unmarshal SG content: %w", v, err)
ale64bit commented 2023-04-10 09:28:06 +00:00
Member
Copy link

can we avoid the acronym 'SG' here?

can we avoid the acronym 'SG' here?
fyrchik commented 2023-04-10 09:59:20 +00:00
Owner
Copy link

This is a refactoring, let's not change any messages.

This is a refactoring, let's not change any messages.
👍 1
ale64bit marked this conversation as resolved
pkg/core/object/fmt.go Outdated
@ -313,3 +327,3 @@
}
return meta, nil
idList := tombstone.Members()
ale64bit commented 2023-04-10 09:33:18 +00:00
Member
Copy link

why the local variable?

why the local variable?
dstepanov-yadro commented 2023-04-10 10:57:06 +00:00
Author
Member
Copy link

fixed

fixed
ale64bit marked this conversation as resolved
dstepanov-yadro force-pushed refactoring/object-3060-remain from 3c4a4c3a38 to e1765dc121 2023-04-10 10:56:32 +00:00 Compare
ale64bit approved these changes 2023-04-10 11:02:51 +00:00
dstepanov-yadro force-pushed refactoring/object-3060-remain from e1765dc121 to 2ce721d52d 2023-04-10 11:11:13 +00:00 Compare
dstepanov-yadro force-pushed refactoring/object-3060-remain from 2ce721d52d to 2c07f831c7 2023-04-10 11:17:31 +00:00 Compare
fyrchik approved these changes 2023-04-10 15:16:55 +00:00
fyrchik merged commit 2c07f831c7 into master 2023-04-10 15:17:00 +00:00
fyrchik referenced this pull request from a commit 2023-04-10 15:17:01 +00:00
[#223] node: Refactor cache usage
Sign in to join this conversation.
Reviewers
No reviewers
ale64bit
fyrchik
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#223
No description provided.
Delete branch "dstepanov-yadro/frostfs-node:refactoring/object-3060-remain"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?