Add tracing spans to PUT, DELETE requests and tree service #242

dstepanov-yadro · 2023-04-12T14:32:07Z

dstepanov-yadro commented

2023-04-12 14:32:07 +00:00

Added tracing to put, delete, search requests.
Added tracing to tree service operations.
Reverted commits with tracing for check ACL and signature operations: there were many such traces, but they did not carry a payload.

I apologize for one large commit: after adding context to one func, linter started issuing that it was necessary to use context in calling func, so it turned out that everything had to be done in one commit.

1. Added tracing to put, delete, search requests. 2. Added tracing to tree service operations. 3. Reverted commits with tracing for check ACL and signature operations: there were many such traces, but they did not carry a payload. I apologize for one large commit: after adding `context` to one func, linter started issuing that it was necessary to use `context` in calling func, so it turned out that everything had to be done in one commit.

dstepanov-yadro force-pushed tracing/put from 5720755e64 to 89b0c6ce4a

2023-04-12 14:33:32 +00:00

Compare

alexvanin referenced this pull request from TrueCloudLab/frostfs-s3-gw

2023-04-12 14:40:48 +00:00

Add tracing support #84

dstepanov-yadro force-pushed tracing/put from 207d65db44 to 1a65c7e64f

2023-04-13 12:39:16 +00:00

Compare

dstepanov-yadro changed title from ~~WIP: Add tracing spans to PUT, DELETE requests and tree service~~ to Add tracing spans to PUT, DELETE requests and tree service

2023-04-13 12:54:39 +00:00

dstepanov-yadro requested review from storage-core-committers 2023-04-13 12:54:45 +00:00

dstepanov-yadro requested review from storage-core-developers 2023-04-13 12:54:45 +00:00

ale64bit requested changes 2023-04-13 14:08:20 +00:00

pkg/local_object_storage/engine/get.go Outdated

													
				@ -48,6 +48,12 @@ func (r GetRes) Object() *objectSDK.Object {

				//

				// Returns an error if executions are blocked (see BlockExecution).

				func (e *StorageEngine) Get(ctx context.Context, prm GetPrm) (res GetRes, err error) {

					ctx, span := tracing.StartSpanFromContext(ctx, "StorageEngine.get",

ale64bit commented

2023-04-13 13:57:11 +00:00

s/get/Get

dstepanov-yadro commented

2023-04-13 14:21:27 +00:00

Poster

fixed

ale64bit marked this conversation as resolved

pkg/local_object_storage/engine/tree.go Outdated

													
				@ -182,2 +265,3 @@

				// TreeList implements the pilorama.Forest interface.

				func (e *StorageEngine) TreeList(cid cidSDK.ID) ([]string, error) {

				func (e *StorageEngine) TreeList(ctx context.Context, cid cidSDK.ID) ([]string, error) {

					ctx, span := tracing.StartSpanFromContext(ctx, "StorageEngine.TreeDrop",

ale64bit commented

2023-04-13 14:00:10 +00:00

s/TreeDrop/TreeList

dstepanov-yadro commented

2023-04-13 14:21:33 +00:00

Poster

fixed

ale64bit marked this conversation as resolved

pkg/services/object/internal/client/client.go Outdated

													
				@ -402,6 +403,9 @@ func (x PutObjectRes) ID() oid.ID {

				//

				// Returns any error which prevented the operation from completing correctly in error return.

				func PutObject(ctx context.Context, prm PutObjectPrm) (*PutObjectRes, error) {

					ctx, span := tracing.StartSpanFromContext(ctx, "client.Put")