TrueCloudLab
/
frostfs-node
18
1
Fork 20
Code Issues 88 Pull Requests 8 Actions Releases Activity

[#139] Refactor blobovnicza exists test to not use chmod #253

Merged
fyrchik merged 1 commits from ale64bit/frostfs-node:fix/139-refactor-blobovnicza-exists-test into master 2023-04-14 10:17:58 +00:00
Conversation 0 Commits 1 Files Changed 3
ale64bit commented 2023-04-14 09:20:01 +00:00
Collaborator

Closing the issue on merge since this was one of the remaining tests that didn't pass under root due to chmod hackery. The other one is dropped in #251.

Signed-off-by: Alejandro Lopez a.lopez@yadro.com

Close #139

Closing the issue on merge since this was one of the remaining tests that didn't pass under root due to chmod hackery. The [other one](https://git.frostfs.info/TrueCloudLab/frostfs-node/src/branch/master/pkg/local_object_storage/shard/dump_test.go#L284) is dropped in https://git.frostfs.info/TrueCloudLab/frostfs-node/pulls/251. Signed-off-by: Alejandro Lopez <a.lopez@yadro.com> Close #139
ale64bit added 1 commit 2023-04-14 09:20:04 +00:00
ci/woodpecker/pr/pre-commit Pipeline was successful Details
ci/woodpecker/push/pre-commit Pipeline was successful Details
41eb3129ae [#139] Refactor blobovnicza exist test to not use chmod 
Signed-off-by: Alejandro Lopez <a.lopez@yadro.com>
ale64bit requested review from storage-core-committers 2023-04-14 09:20:32 +00:00
ale64bit requested review from storage-core-developers 2023-04-14 09:20:32 +00:00
fyrchik approved these changes 2023-04-14 09:21:33 +00:00
internal/logs/logs.go
@ -491,3 +491,3 @@
NetmapNonAlphabetModeIgnoreRemoveNodeFromSubnetNotification = "non alphabet mode, ignore remove node from subnet notification" // Info in ../node/pkg/innerring/processors/netmap/process_peers.go
NetmapCouldNotGetNetworkMapCandidates = "could not get network map candidates" // Warn in ../node/pkg/innerring/processors/netmap/process_peers.go
NetmapCouldNotUnmarshalSubnetId = "could not unmarshal subnet id" // Warn in ../node/pkg/innerring/processors/netmap/process_peers.go
NetmapCouldNotUnmarshalSubnetID = "could not unmarshal subnet id" // Warn in ../node/pkg/innerring/processors/netmap/process_peers.go
fyrchik commented 2023-04-14 09:21:29 +00:00
Owner

Can we do it in a separate commit?

Can we do it in a separate commit?
ale64bit commented 2023-04-14 09:23:13 +00:00
Poster
Collaborator

no. The precommit won't let me. Not sure how it got through in the first place.

no. The precommit won't let me. Not sure how it got through in the first place.
acid-ant approved these changes 2023-04-14 09:29:25 +00:00
fyrchik merged commit 41eb3129ae into master 2023-04-14 10:17:58 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
fyrchik
acid-ant
TrueCloudLab/storage-core-developers
Labels
Clear labels   
P0

Highest   
P1

High   
P2

Medium   
P3

Low   
badger

Badger DB related issues   
frostfs-adm
   
frostfs-cli
   
frostfs-ir
   
frostfs-lens
   
frostfs-node
   
good first issue

Good for newcomers   
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff   
blocked

The issue or PR is blocked by something   
bug

Something is not working   
config

Configuration format update or breaking change   
discussion

Talking about something in order to reach a decision or to exchange ideas   
documentation

Documentation related   
duplicate

This issue or pull request already exists   
enhancement

New feature   
go

Language features adoption   
help wanted

Extra attention is needed   
internal
   
invalid

Something is wrong   
kludge

This is a kludge and we know it   
observability

Related to metrics, tracing and logs   
perfomance

Perfomance related   
question

More information is needed   
refactoring

Refactoring   
wontfix

This won't be fixed
No Label
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#253
There is no content yet.
Delete Branch "ale64bit/frostfs-node:fix/139-refactor-blobovnicza-exists-test"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?