TrueCloudLab/frostfs-node
20
1
Fork 28
Code Issues 114 Pull requests 4 Projects Releases 2 Activity Actions

Fix/WC init race condition #261

Merged
fyrchik merged 1 commit from fix/races-in-WC into master 2023-04-19 09:29:08 +00:00
Conversation 0 Commits 1 Files changed 1 +8
carpawell commented 2023-04-17 15:55:03 +00:00
Contributor
Copy link

Do not use WC's internals in the initialization routines without mode
protection. WC should be able to change its mode even if the initialization
is not finished yet.

Signed-off-by: Pavel Karpy p.karpy@yadro.com

Was hard to reproduce (1/10, i guess). Not a perfect solution but the perfect lies somewhere near WC refactor i guess (without cache, complex async initialization etc).

Do not use WC's internals in the initialization routines without mode protection. WC should be able to change its mode even if the initialization is not finished yet. Signed-off-by: Pavel Karpy <p.karpy@yadro.com> Was hard to reproduce (1/10, i guess). Not a perfect solution but the perfect lies somewhere near WC refactor i guess (without cache, complex async initialization etc).
carpawell self-assigned this 2023-04-17 15:55:03 +00:00
requested reviews from fyrchik, storage-core-developers, storage-core-committers 2023-04-18 07:09:06 +00:00
acid-ant approved these changes 2023-04-18 07:35:42 +00:00
fyrchik reviewed 2023-04-18 07:54:41 +00:00
pkg/local_object_storage/writecache/init.go Outdated
@ -89,1 +89,4 @@
c.modeMtx.RLock()
_, _ = c.fsTree.Iterate(prm)
c.modeMtx.RUnlock()
fyrchik commented 2023-04-18 07:54:41 +00:00
Owner
Copy link

Why not defer?

Why not `defer`?
carpawell commented 2023-04-18 14:49:20 +00:00
Author
Contributor
Copy link

wanted it to unlock as fast as possible, without logging and other (possible in future) things. changed to be deferred

wanted it to unlock as fast as possible, without logging and other (possible in future) things. changed to be deferred
carpawell force-pushed fix/races-in-WC from 1d4601f2f7 to f87f44725a 2023-04-18 14:49:14 +00:00 Compare
dstepanov-yadro approved these changes 2023-04-18 15:27:18 +00:00
fyrchik merged commit 20cd080323 into master 2023-04-19 09:29:08 +00:00
fyrchik deleted branch fix/races-in-WC 2023-04-19 09:29:08 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
fyrchik
acid-ant
dstepanov-yadro
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
carpawell
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#261
No description provided.
Delete branch "fix/races-in-WC"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?