Investigate potential problems with big amount of alphabet nodes #295

New issue

Closed

opened 2023-05-02 08:11:53 +00:00 by fyrchik · 3 comments

fyrchik commented

2023-05-02 08:11:53 +00:00

Owner

frostfs-adm has tests for deploying 1, 4 and 7 nodes. These numbers are the most frequent. I would like to add the biggest amount of alphabet nodes (all letters), just to check our limits.

There are 2 potential problems here, which we can look for:

Some letters have dot . in their string representation. This can play not nicely with NNS domains registration.
Many signers can increase transaction size, let's ensure it still passes neo-go limits (especially during contract deployment).

frostfs-adm has tests for deploying 1, 4 and 7 nodes. These numbers are the most frequent. I would like to add the biggest amount of alphabet nodes (all letters), just to check our limits. There are 2 potential problems here, which we can look for: 1. Some letters have dot `.` in their string representation. This can play not nicely with NNS domains registration. 2. Many signers can increase transaction size, let's ensure it still passes neo-go limits (especially during contract deployment).

fyrchik added the

frostfs-adm

label 2023-05-02 08:11:53 +00:00

fyrchik added this to the v0.37.0 milestone 2023-05-02 08:11:57 +00:00

ale64bit commented

2023-05-05 10:01:13 +00:00

Member

Currently the test passes with up to 15 nodes.

Using 16 or more nodes runs into the following limit in Stage 5:

https://github.com/nspcc-dev/neo-go/blob/master/pkg/core/transaction/transaction.go#L27

And running with many more nodes (e.g. 31 or more) hits a transaction limit in Stage 1:

can't send transfer transaction: invalid transaction: byte-slice is too big (1386)

Currently the test passes with up to 15 nodes. Using 16 or more nodes runs into the following limit in Stage 5: - https://github.com/nspcc-dev/neo-go/blob/master/pkg/core/transaction/transaction.go#L27 And running with many more nodes (e.g. 31 or more) hits a transaction limit in Stage 1: ``` can't send transfer transaction: invalid transaction: byte-slice is too big (1386) ```

fyrchik commented

2023-05-05 10:38:16 +00:00

Author

Owner

Ok, let's fix everything incrementally, I will create tasks.

👍 1

fyrchik referenced this issue

2023-05-12 10:14:14 +00:00

Register candidates in the frostfs-adm in separate transactions #341