Morph client always use the first endpoint on creation #304

Closed
opened 2023-05-02 14:16:39 +00:00 by BrookDaniel · 0 comments

Expected Behavior

The valid endpoint from the endpoints list should be used during creation

Current Behavior

cli.client, act, err = cli.newCli(ctx, cli.endpoints.list[0].Address)

When we have priority 1 for localhost and stopped neo-go on current node, always will receive error "could not create RPC client: WS client creation: dial tcp [::1]:40332: connect: connection refused". Endpoints from the list will not used.

Possible Solution

Steps to Reproduce (for bugs)

Stopping neo-go service
systemctl restart to-cm - will fail with error like "panic: neogo is not accessible: could not create RPC client: WS client creation: dial tcp [::1]:40332: connect: connection refused"

Context

Regression

Your Environment

  • Version used:
  • Server setup and configuration:
  • Operating System and version (uname -a):
<!-- Provide a general summary of the issue in the Title above --> ## Expected Behavior The valid endpoint from the endpoints list should be used during creation ## Current Behavior https://git.frostfs.info/TrueCloudLab/frostfs-node/src/commit/eca5c210dd21c5c6f30c5817c45b808589a2c651/pkg/morph/client/constructor.go#L140 When we have priority 1 for localhost and stopped neo-go on current node, always will receive error "could not create RPC client: WS client creation: dial tcp [::1]:40332: connect: connection refused". Endpoints from the list will not used. ## Possible Solution <!-- Not obligatory If no reason/fix/additions for the bug can be suggested, uncomment the following phrase: No fix can be suggested by a QA engineer. Further solutions shall be up to developers. --> ## Steps to Reproduce (for bugs) Stopping neo-go service systemctl restart to-cm - will fail with error like "panic: neogo is not accessible: could not create RPC client: WS client creation: dial tcp [::1]:40332: connect: connection refused" ## Context <!-- How has this issue affected you? What are you trying to accomplish? Providing context helps us come up with a solution that is most useful in the real world --> ## Regression <!-- Is this issue a regression? (Yes / No) If Yes, optionally please include version or commit id or PR# that caused this regression, if you have these details --> ## Your Environment <!-- Include as many relevant details about the environment you experienced the bug in --> * Version used: * Server setup and configuration: * Operating System and version (`uname -a`):
BrookDaniel added the
triage
label 2023-05-02 14:16:39 +00:00
fyrchik changed title from при создании morphclient.New, всегда используется самый приоритетный endpoint, а не доступный to Morph client always use the first endpoint on creation 2023-05-02 14:17:45 +00:00
fyrchik added the
frostfs-node
label 2023-05-02 14:29:00 +00:00
acid-ant was assigned by fyrchik 2023-05-03 07:50:49 +00:00
snegurochka added the
bug
label 2023-05-03 17:14:38 +00:00
fyrchik added this to the v0.37.0 milestone 2023-05-04 06:50:12 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#304
No description provided.