TrueCloudLab
/
frostfs-node
19
1
Fork 20
Code Issues 93 Pull Requests 9 Actions Releases Activity

Parallelize locode DB generation #309

Merged
fyrchik merged 2 commits from fyrchik/frostfs-node:optimize-locode into master 2023-05-12 09:59:15 +00:00
Conversation 0 Commits 2 Files Changed 5
fyrchik commented 2023-05-03 13:26:40 +00:00
Owner
There is no content yet.
fyrchik force-pushed optimize-locode from cc6d85828d to c6ef54761f 2023-05-03 13:27:41 +00:00 Compare
fyrchik force-pushed optimize-locode from c6ef54761f to c13d395029 2023-05-03 13:28:18 +00:00 Compare
fyrchik force-pushed optimize-locode from c13d395029 to ab2393577c 2023-05-04 08:04:26 +00:00 Compare
fyrchik force-pushed optimize-locode from ab2393577c to ce4d6f88da 2023-05-04 08:08:11 +00:00 Compare
fyrchik force-pushed optimize-locode from ce4d6f88da to cbb9765ee1 2023-05-04 14:00:53 +00:00 Compare
carpawell approved these changes 2023-05-04 14:16:28 +00:00
pkg/util/locode/db/db.go Outdated
@ -78,2 +79,2 @@
return table.IterateAll(func(tableRecord locode.Record) error {
if tableRecord.LOCODE.LocationCode() == "" {
var errG errgroup.Group
errG.SetLimit(128)
carpawell commented 2023-05-04 14:14:29 +00:00
Collaborator

magic?

magic?
fyrchik commented 2023-05-05 07:30:35 +00:00
Poster
Owner

It was a wild guess. We cannot pick optimal value "for all", just pick a sane default. Added a comment.

It was a wild guess. We cannot pick optimal value "for all", just pick a sane default. Added a comment.
fyrchik force-pushed optimize-locode from cbb9765ee1 to 1980631821 2023-05-05 07:30:25 +00:00 Compare
fyrchik force-pushed optimize-locode from 1980631821 to e74751d204 2023-05-05 07:35:49 +00:00 Compare
carpawell approved these changes 2023-05-05 11:24:55 +00:00
acid-ant approved these changes 2023-05-12 09:47:20 +00:00
fyrchik merged commit 02c02974b3 into master 2023-05-12 09:59:15 +00:00
fyrchik deleted branch optimize-locode 2023-05-12 09:59:15 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
carpawell
acid-ant
Labels
Clear labels   
P0

Highest   
P1

High   
P2

Medium   
P3

Low   
badger

Badger DB related issues   
frostfs-adm
   
frostfs-cli
   
frostfs-ir
   
frostfs-lens
   
frostfs-node
   
good first issue

Good for newcomers   
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff   
blocked

The issue or PR is blocked by something   
bug

Something is not working   
config

Configuration format update or breaking change   
discussion

Talking about something in order to reach a decision or to exchange ideas   
documentation

Documentation related   
duplicate

This issue or pull request already exists   
enhancement

New feature   
go

Language features adoption   
help wanted

Extra attention is needed   
internal
   
invalid

Something is wrong   
kludge

This is a kludge and we know it   
observability

Related to metrics, tracing and logs   
perfomance

Perfomance related   
question

More information is needed   
refactoring

Refactoring   
wontfix

This won't be fixed
No Label
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#309
There is no content yet.
Delete Branch "fyrchik/frostfs-node:optimize-locode"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?