Minor FSTree improvements #31

carpawell · 2023-01-25T14:35:17Z

fyrchik commented

2023-01-25 14:35:17 +00:00

(Migrated from github.com)

No description provided.

carpawell (Migrated from github.com) reviewed 2023-01-31 13:12:23 +00:00

pkg/local_object_storage/blobstor/fstree/fstree.go

					
				@ -78,2 +76,4 @@

					if i == -1 {

						return oid.Address{}, errors.New("invalid address")

					}

carpawell (Migrated from github.com) commented

2023-01-31 13:04:36 +00:00

some bench to commit/PR decs about the enhancement?

fyrchik (Migrated from github.com) reviewed 2023-02-10 05:08:45 +00:00

pkg/local_object_storage/blobstor/fstree/fstree.go

					
				@ -78,2 +76,4 @@

					if i == -1 {

						return oid.Address{}, errors.New("invalid address")

					}

fyrchik (Migrated from github.com) commented

2023-02-10 05:08:39 +00:00

Fixed

acid-ant (Migrated from github.com) approved these changes 2023-02-10 06:48:09 +00:00

acid-ant commented

2023-02-10 06:48:53 +00:00

(Migrated from github.com)

Changelog needs to be updated.

fyrchik commented

2023-02-10 09:49:25 +00:00

(Migrated from github.com)

IMO it isn't worth a line in changelog -- purely internal opitimizations.

carpawell referenced this pull request from a commit

2023-03-22 17:36:30 +00:00

[#31] fstree: Speedup string-to-address conversion

carpawell referenced this pull request from a commit

2023-03-22 17:36:30 +00:00

[#31] fstree: Do not check for a file existence twice

carpawell referenced this pull request from a commit

2023-03-22 17:36:30 +00:00

[#31] fstree: Optimize `treePath`

Sign in to join this conversation.

No reviewers

acid-ant

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#31

Rows
Columns