Race in processors tests #311

New Issue

Closed

opened 2023-05-03 14:36:56 +00:00 by carpawell · 0 comments

carpawell commented

2023-05-03 14:36:56 +00:00

Collaborator

Have faced that after rebasing on master:

WARNING: DATA RACE
Read at 0x00c0001605a0 by goroutine 12:
  reflect.Value.Uint()
      /usr/local/go/src/reflect/value.go:2580 +0xa33
  reflect.deepValueEqual()
      /usr/local/go/src/reflect/deepequal.go:162 +0x880
  reflect.deepValueEqual()
      /usr/local/go/src/reflect/deepequal.go:93 +0x2484
  reflect.deepValueEqual()
      /usr/local/go/src/reflect/deepequal.go:127 +0x1712
  reflect.deepValueEqual()
      /usr/local/go/src/reflect/deepequal.go:130 +0x1e9b
  reflect.deepValueEqual()
      /usr/local/go/src/reflect/deepequal.go:130 +0x1e9b
  reflect.deepValueEqual()
      /usr/local/go/src/reflect/deepequal.go:113 +0x1fb6
  reflect.DeepEqual()
      /usr/local/go/src/reflect/deepequal.go:237 +0x479
  github.com/stretchr/testify/assert.ObjectsAreEqual()
      /home/carpawell/go/pkg/mod/github.com/stretchr/testify@v1.8.2/assert/assertions.go:65 +0x184
  github.com/stretchr/testify/assert.ObjectsAreEqualValues()
      /home/carpawell/go/pkg/mod/github.com/stretchr/testify@v1.8.2/assert/assertions.go:81 +0x79
  github.com/stretchr/testify/assert.EqualValues()
      /home/carpawell/go/pkg/mod/github.com/stretchr/testify@v1.8.2/assert/assertions.go:464 +0xc9
  github.com/stretchr/testify/require.EqualValues()
      /home/carpawell/go/pkg/mod/github.com/stretchr/testify@v1.8.2/require/require.go:206 +0xc8
  git.frostfs.info/TrueCloudLab/frostfs-node/pkg/innerring/processors/frostfs.TestHandleUnbind()
      /home/carpawell/NSPCC/git/neofs-node/pkg/innerring/processors/frostfs/handlers_test.go:260 +0xb1d
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:1446 +0x216
  testing.(*T).Run.func1()
      /usr/local/go/src/testing/testing.go:1493 +0x47

Previous write at 0x00c0001605a0 by goroutine 35:
  git.frostfs.info/TrueCloudLab/frostfs-node/pkg/innerring/processors/frostfs.(*Processor).approveBindCommon()
      /home/carpawell/NSPCC/git/neofs-node/pkg/innerring/processors/frostfs/process_bind.go:92 +0x393
  git.frostfs.info/TrueCloudLab/frostfs-node/pkg/innerring/processors/frostfs.(*Processor).processBind()
      /home/carpawell/NSPCC/git/neofs-node/pkg/innerring/processors/frostfs/process_bind.go:42 +0x30b
  git.frostfs.info/TrueCloudLab/frostfs-node/pkg/innerring/processors/frostfs.(*Processor).handleBind.func1()
      /home/carpawell/NSPCC/git/neofs-node/pkg/innerring/processors/frostfs/handlers.go:86 +0x9d
  github.com/panjf2000/ants/v2.(*goWorker).run.func1()
      /home/carpawell/go/pkg/mod/github.com/panjf2000/ants/v2@v2.4.0/worker.go:68 +0xe9

Have faced that after rebasing on `master`: ``` WARNING: DATA RACE Read at 0x00c0001605a0 by goroutine 12: reflect.Value.Uint() /usr/local/go/src/reflect/value.go:2580 +0xa33 reflect.deepValueEqual() /usr/local/go/src/reflect/deepequal.go:162 +0x880 reflect.deepValueEqual() /usr/local/go/src/reflect/deepequal.go:93 +0x2484 reflect.deepValueEqual() /usr/local/go/src/reflect/deepequal.go:127 +0x1712 reflect.deepValueEqual() /usr/local/go/src/reflect/deepequal.go:130 +0x1e9b reflect.deepValueEqual() /usr/local/go/src/reflect/deepequal.go:130 +0x1e9b reflect.deepValueEqual() /usr/local/go/src/reflect/deepequal.go:113 +0x1fb6 reflect.DeepEqual() /usr/local/go/src/reflect/deepequal.go:237 +0x479 github.com/stretchr/testify/assert.ObjectsAreEqual() /home/carpawell/go/pkg/mod/github.com/stretchr/testify@v1.8.2/assert/assertions.go:65 +0x184 github.com/stretchr/testify/assert.ObjectsAreEqualValues() /home/carpawell/go/pkg/mod/github.com/stretchr/testify@v1.8.2/assert/assertions.go:81 +0x79 github.com/stretchr/testify/assert.EqualValues() /home/carpawell/go/pkg/mod/github.com/stretchr/testify@v1.8.2/assert/assertions.go:464 +0xc9 github.com/stretchr/testify/require.EqualValues() /home/carpawell/go/pkg/mod/github.com/stretchr/testify@v1.8.2/require/require.go:206 +0xc8 git.frostfs.info/TrueCloudLab/frostfs-node/pkg/innerring/processors/frostfs.TestHandleUnbind() /home/carpawell/NSPCC/git/neofs-node/pkg/innerring/processors/frostfs/handlers_test.go:260 +0xb1d testing.tRunner() /usr/local/go/src/testing/testing.go:1446 +0x216 testing.(*T).Run.func1() /usr/local/go/src/testing/testing.go:1493 +0x47 Previous write at 0x00c0001605a0 by goroutine 35: git.frostfs.info/TrueCloudLab/frostfs-node/pkg/innerring/processors/frostfs.(*Processor).approveBindCommon() /home/carpawell/NSPCC/git/neofs-node/pkg/innerring/processors/frostfs/process_bind.go:92 +0x393 git.frostfs.info/TrueCloudLab/frostfs-node/pkg/innerring/processors/frostfs.(*Processor).processBind() /home/carpawell/NSPCC/git/neofs-node/pkg/innerring/processors/frostfs/process_bind.go:42 +0x30b git.frostfs.info/TrueCloudLab/frostfs-node/pkg/innerring/processors/frostfs.(*Processor).handleBind.func1() /home/carpawell/NSPCC/git/neofs-node/pkg/innerring/processors/frostfs/handlers.go:86 +0x9d github.com/panjf2000/ants/v2.(*goWorker).run.func1() /home/carpawell/go/pkg/mod/github.com/panjf2000/ants/v2@v2.4.0/worker.go:68 +0xe9 ```