TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 100 Pull requests 4 Projects Releases 1 Activity Actions

Data race in frostfs-adm tests #346

New issue
Closed
opened 2023-05-15 08:46:15 +00:00 by fyrchik · 0 comments
fyrchik commented 2023-05-15 08:46:15 +00:00
Owner
Copy link
==================
==================
WARNING: DATA RACE
Read at 0x00c00054c068 by goroutine 41:
  github.com/nspcc-dev/neo-go/pkg/wallet.(*Account).ConvertMultisig()
      /home/dzeta/go/pkg/mod/github.com/nspcc-dev/neo-go@v0.100.1/pkg/wallet/account.go:253 +0x20b
  git.frostfs.info/TrueCloudLab/frostfs-node/cmd/frostfs-adm/internal/modules/morph.addMultisigAccount()
      /repo/frostfs/node/cmd/frostfs-adm/internal/modules/morph/generate.go:127 +0x158
  git.frostfs.info/TrueCloudLab/frostfs-node/cmd/frostfs-adm/internal/modules/morph.initializeWallets.func1()
      /repo/frostfs/node/cmd/frostfs-adm/internal/modules/morph/generate.go:105 +0x164
  golang.org/x/sync/errgroup.(*Group).Go.func1()
      /home/dzeta/go/pkg/mod/golang.org/x/sync@v0.1.0/errgroup/errgroup.go:75 +0x82

Previous write at 0x00c00054c068 by goroutine 40:
  github.com/nspcc-dev/neo-go/pkg/crypto/keys.PublicKeys.Swap()
      /home/dzeta/go/pkg/mod/github.com/nspcc-dev/neo-go@v0.100.1/pkg/crypto/keys/publickey.go:49 +0xe4
  github.com/nspcc-dev/neo-go/pkg/crypto/keys.(*PublicKeys).Swap()
      <autogenerated>:1 +0x29
  sort.insertionSort()
      /usr/lib/go/src/sort/zsortinterface.go:13 +0x86
  sort.pdqsort()
      /usr/lib/go/src/sort/zsortinterface.go:73 +0x36d
  sort.Sort()
      /usr/lib/go/src/sort/sort.go:48 +0x74
  github.com/nspcc-dev/neo-go/pkg/smartcontract.CreateMultiSigRedeemScript()
      /home/dzeta/go/pkg/mod/github.com/nspcc-dev/neo-go@v0.100.1/pkg/smartcontract/contract.go:28 +0x199
  github.com/nspcc-dev/neo-go/pkg/wallet.(*Account).ConvertMultisig()
      /home/dzeta/go/pkg/mod/github.com/nspcc-dev/neo-go@v0.100.1/pkg/wallet/account.go:263 +0x24f
  git.frostfs.info/TrueCloudLab/frostfs-node/cmd/frostfs-adm/internal/modules/morph.addMultisigAccount()
      /repo/frostfs/node/cmd/frostfs-adm/internal/modules/morph/generate.go:127 +0x158
  git.frostfs.info/TrueCloudLab/frostfs-node/cmd/frostfs-adm/internal/modules/morph.initializeWallets.func1()
      /repo/frostfs/node/cmd/frostfs-adm/internal/modules/morph/generate.go:105 +0x164
  golang.org/x/sync/errgroup.(*Group).Go.func1()
      /home/dzeta/go/pkg/mod/golang.org/x/sync@v0.1.0/errgroup/errgroup.go:75 +0x82

Goroutine 41 (running) created at:
  golang.org/x/sync/errgroup.(*Group).Go()
      /home/dzeta/go/pkg/mod/golang.org/x/sync@v0.1.0/errgroup/errgroup.go:72 +0x12e
  git.frostfs.info/TrueCloudLab/frostfs-node/cmd/frostfs-adm/internal/modules/morph.initializeWallets()
      /repo/frostfs/node/cmd/frostfs-adm/internal/modules/morph/generate.go:104 +0xa24
  git.frostfs.info/TrueCloudLab/frostfs-node/cmd/frostfs-adm/internal/modules/morph.generateAlphabetCreds()
      /repo/frostfs/node/cmd/frostfs-adm/internal/modules/morph/generate.go:45 +0x144
  git.frostfs.info/TrueCloudLab/frostfs-node/cmd/frostfs-adm/internal/modules/morph.TestGenerateAlphabet()
      /repo/frostfs/node/cmd/frostfs-adm/internal/modules/morph/generate_test.go:73 +0x7dd
  testing.tRunner()
      /usr/lib/go/src/testing/testing.go:1576 +0x216
  testing.(*T).Run.func1()
      /usr/lib/go/src/testing/testing.go:1629 +0x47

Goroutine 40 (running) created at:
  golang.org/x/sync/errgroup.(*Group).Go()
      /home/dzeta/go/pkg/mod/golang.org/x/sync@v0.1.0/errgroup/errgroup.go:72 +0x12e
  git.frostfs.info/TrueCloudLab/frostfs-node/cmd/frostfs-adm/internal/modules/morph.initializeWallets()
      /repo/frostfs/node/cmd/frostfs-adm/internal/modules/morph/generate.go:104 +0xa24
  git.frostfs.info/TrueCloudLab/frostfs-node/cmd/frostfs-adm/internal/modules/morph.generateAlphabetCreds()
      /repo/frostfs/node/cmd/frostfs-adm/internal/modules/morph/generate.go:45 +0x144
  git.frostfs.info/TrueCloudLab/frostfs-node/cmd/frostfs-adm/internal/modules/morph.TestGenerateAlphabet()
      /repo/frostfs/node/cmd/frostfs-adm/internal/modules/morph/generate_test.go:73 +0x7dd
  testing.tRunner()
      /usr/lib/go/src/testing/testing.go:1576 +0x216
  testing.(*T).Run.func1()
      /usr/lib/go/src/testing/testing.go:1629 +0x47
==================
``` ================== ================== WARNING: DATA RACE Read at 0x00c00054c068 by goroutine 41: github.com/nspcc-dev/neo-go/pkg/wallet.(*Account).ConvertMultisig() /home/dzeta/go/pkg/mod/github.com/nspcc-dev/neo-go@v0.100.1/pkg/wallet/account.go:253 +0x20b git.frostfs.info/TrueCloudLab/frostfs-node/cmd/frostfs-adm/internal/modules/morph.addMultisigAccount() /repo/frostfs/node/cmd/frostfs-adm/internal/modules/morph/generate.go:127 +0x158 git.frostfs.info/TrueCloudLab/frostfs-node/cmd/frostfs-adm/internal/modules/morph.initializeWallets.func1() /repo/frostfs/node/cmd/frostfs-adm/internal/modules/morph/generate.go:105 +0x164 golang.org/x/sync/errgroup.(*Group).Go.func1() /home/dzeta/go/pkg/mod/golang.org/x/sync@v0.1.0/errgroup/errgroup.go:75 +0x82 Previous write at 0x00c00054c068 by goroutine 40: github.com/nspcc-dev/neo-go/pkg/crypto/keys.PublicKeys.Swap() /home/dzeta/go/pkg/mod/github.com/nspcc-dev/neo-go@v0.100.1/pkg/crypto/keys/publickey.go:49 +0xe4 github.com/nspcc-dev/neo-go/pkg/crypto/keys.(*PublicKeys).Swap() <autogenerated>:1 +0x29 sort.insertionSort() /usr/lib/go/src/sort/zsortinterface.go:13 +0x86 sort.pdqsort() /usr/lib/go/src/sort/zsortinterface.go:73 +0x36d sort.Sort() /usr/lib/go/src/sort/sort.go:48 +0x74 github.com/nspcc-dev/neo-go/pkg/smartcontract.CreateMultiSigRedeemScript() /home/dzeta/go/pkg/mod/github.com/nspcc-dev/neo-go@v0.100.1/pkg/smartcontract/contract.go:28 +0x199 github.com/nspcc-dev/neo-go/pkg/wallet.(*Account).ConvertMultisig() /home/dzeta/go/pkg/mod/github.com/nspcc-dev/neo-go@v0.100.1/pkg/wallet/account.go:263 +0x24f git.frostfs.info/TrueCloudLab/frostfs-node/cmd/frostfs-adm/internal/modules/morph.addMultisigAccount() /repo/frostfs/node/cmd/frostfs-adm/internal/modules/morph/generate.go:127 +0x158 git.frostfs.info/TrueCloudLab/frostfs-node/cmd/frostfs-adm/internal/modules/morph.initializeWallets.func1() /repo/frostfs/node/cmd/frostfs-adm/internal/modules/morph/generate.go:105 +0x164 golang.org/x/sync/errgroup.(*Group).Go.func1() /home/dzeta/go/pkg/mod/golang.org/x/sync@v0.1.0/errgroup/errgroup.go:75 +0x82 Goroutine 41 (running) created at: golang.org/x/sync/errgroup.(*Group).Go() /home/dzeta/go/pkg/mod/golang.org/x/sync@v0.1.0/errgroup/errgroup.go:72 +0x12e git.frostfs.info/TrueCloudLab/frostfs-node/cmd/frostfs-adm/internal/modules/morph.initializeWallets() /repo/frostfs/node/cmd/frostfs-adm/internal/modules/morph/generate.go:104 +0xa24 git.frostfs.info/TrueCloudLab/frostfs-node/cmd/frostfs-adm/internal/modules/morph.generateAlphabetCreds() /repo/frostfs/node/cmd/frostfs-adm/internal/modules/morph/generate.go:45 +0x144 git.frostfs.info/TrueCloudLab/frostfs-node/cmd/frostfs-adm/internal/modules/morph.TestGenerateAlphabet() /repo/frostfs/node/cmd/frostfs-adm/internal/modules/morph/generate_test.go:73 +0x7dd testing.tRunner() /usr/lib/go/src/testing/testing.go:1576 +0x216 testing.(*T).Run.func1() /usr/lib/go/src/testing/testing.go:1629 +0x47 Goroutine 40 (running) created at: golang.org/x/sync/errgroup.(*Group).Go() /home/dzeta/go/pkg/mod/golang.org/x/sync@v0.1.0/errgroup/errgroup.go:72 +0x12e git.frostfs.info/TrueCloudLab/frostfs-node/cmd/frostfs-adm/internal/modules/morph.initializeWallets() /repo/frostfs/node/cmd/frostfs-adm/internal/modules/morph/generate.go:104 +0xa24 git.frostfs.info/TrueCloudLab/frostfs-node/cmd/frostfs-adm/internal/modules/morph.generateAlphabetCreds() /repo/frostfs/node/cmd/frostfs-adm/internal/modules/morph/generate.go:45 +0x144 git.frostfs.info/TrueCloudLab/frostfs-node/cmd/frostfs-adm/internal/modules/morph.TestGenerateAlphabet() /repo/frostfs/node/cmd/frostfs-adm/internal/modules/morph/generate_test.go:73 +0x7dd testing.tRunner() /usr/lib/go/src/testing/testing.go:1576 +0x216 testing.(*T).Run.func1() /usr/lib/go/src/testing/testing.go:1629 +0x47 ================== ```
fyrchik added the
bug
P0
frostfs-adm
 labels 2023-05-15 08:46:32 +00:00
fyrchik self-assigned this 2023-05-15 08:48:11 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
support/v0.42
support/v0.38
support/v0.37
support/v0.36
support/v0.34
support/v0.30
support/v0.27
v0.44.0-rc.13
v0.44.0-rc.12
v0.44.0-rc.11
v0.42.16
v0.44.0-rc.10
v0.44.0-rc.9
v0.44.0-rc.8
v0.44.0-rc.7
v0.44.0-rc.6
v0.44.0-rc.5
v0.44.0-rc.4
v0.44.0-rc.3
v0.44.0-rc.2
v0.44.0-rc.1
v0.43.2
v0.43.1
v0.43.0
v0.42.15
v0.42.14
v0.42.13
v0.42.12
v0.42.11
v0.42.10
v0.42.9
v0.42.8
v0.42.7
v0.42.6
v0.42.5
v0.42.4
v0.42.3
v0.42.2
v0.42.1
v0.42.0
v0.42.0-rc.9
v0.42.0-rc.8
v0.42.0-rc.7
v0.38.9
v0.42.0-rc.6
v0.42.0-rc.5
v0.42.0-rc.4
v0.42.0-rc.3
v0.42.0-rc.2
v0.42.0-rc.1
v0.38.8
v0.41.0
v0.38.7
v0.40.0
v0.39.0
v0.38.6
v0.38.5
v0.38.4
v0.38.3
v0.38.2
v0.38.1
v0.38.0
v0.38.0-rc.2
v0.38.0-rc.1
v0.37.0
v0.37.0-rc.1
v0.36.0
v0.34.0
v0.22.1
v0.22.0
v0.21.1
v0.21.0
v0.20.0
v0.19.0
v0.18.0
v0.17.0
v0.16.0
v0.15.0
v0.14.3
v0.14.2
v0.14.1
v0.14.0
v0.14.0-rc.1
v0.13.2
v0.13.1
v0.13.0
v0.13.0-rc.1
v0.12.1
v0.12.0
v0.12.0-rc3
v0.12.0-rc2
v0.12.0-rc1
v0.11.0
v0.10.0
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
fyrchik
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#346
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?