Drop notaryless code #361

dstepanov-yadro · 2023-05-17T12:45:51Z

dstepanov-yadro commented

2023-05-17 12:45:51 +00:00

Closes #338

dstepanov-yadro force-pushed fix/drop-notaryless from de5206a7b3 to 60fd008df1

2023-05-17 14:00:37 +00:00

Compare

dstepanov-yadro force-pushed fix/drop-notaryless from 7097d4203d to 4dd52f90e0

2023-05-18 06:54:10 +00:00

Compare

dstepanov-yadro force-pushed fix/drop-notaryless from 4dd52f90e0 to d7ff51af09

2023-05-18 07:10:57 +00:00

Compare

dstepanov-yadro requested review from storage-core-committers 2023-05-18 08:33:08 +00:00

dstepanov-yadro requested review from storage-core-developers 2023-05-18 08:33:08 +00:00

dstepanov-yadro changed title from ~~WIP: Drop notaryless code~~ to Drop notaryless code

2023-05-18 08:33:30 +00:00

acid-ant reviewed 2023-05-18 08:46:39 +00:00

pkg/innerring/config/fee.go Outdated

					
				@ -9,3 +9,3 @@

				// invocations without notary support.

				type FeeConfig struct {

					registerNamedCnr,

					//registerNamedCnr,

acid-ant commented

2023-05-18 08:46:39 +00:00

Why we need to keep it?

dstepanov-yadro commented

2023-05-18 09:29:08 +00:00

dropped

acid-ant approved these changes 2023-05-18 09:02:03 +00:00

ale64bit approved these changes 2023-05-18 09:12:44 +00:00

pkg/innerring/initialization.go

					
				@ -263,9 +258,9 @@ func (s *Server) initContainerProcessor(cfg *viper.Viper, cnrClient *container.C

						PoolSize:        cfg.GetInt("workers.container"),

						AlphabetState:   s,

						ContainerClient: cnrClient,

						MorphClient:     cnrClient.Morph(),

ale64bit commented

2023-05-18 09:07:04 +00:00

it's a bit strange to pass both cnrClient and cnrClient.Morph(). Can we not resolve the morph client from cnrClient and avoid the extra field? Or is it so that it can mocked/tested?

it's a bit strange to pass both `cnrClient` and `cnrClient.Morph()`. Can we not resolve the morph client from `cnrClient` and avoid the extra field? Or is it so that it can mocked/tested?

dstepanov-yadro commented

2023-05-18 09:27:44 +00:00

Yes, it is so that it can mocked/tested.

👍 1

ale64bit marked this conversation as resolved

dstepanov-yadro force-pushed fix/drop-notaryless from af1fff4f00 to 1af9cd3667

2023-05-18 09:28:54 +00:00

Compare

aarifullin approved these changes 2023-05-19 11:24:01 +00:00

fyrchik reviewed 2023-05-24 07:51:32 +00:00

config/example/ir.yaml

					
				@ -49,7 +49,6 @@ locode:

				fee:

				  main_chain: 50000000                 # Fixed8 value of extra GAS fee for mainchain contract invocation; ignore if notary is enabled in mainchain

				  side_chain: 200000000                # Fixed8 value of extra GAS fee for sidechain contract invocation; ignore if notary is enabled in sidechain