node: Stop GC once termination signal recieved #366

New issue

Closed

opened 2023-05-18 08:12:23 +00:00 by acid-ant · 0 comments

acid-ant commented

2023-05-18 08:12:23 +00:00

Member

https://git.frostfs.info/TrueCloudLab/frostfs-node/src/branch/master/pkg/local_object_storage/shard/gc.go#L199

Expected Behavior
GC stops once termination signal received.

Current Behavior
GC continue working on even we stop it.
Also, it is possible that timer continues working. See tickRemover():
https://git.frostfs.info/TrueCloudLab/frostfs-node/src/branch/master/pkg/local_object_storage/shard/gc.go#L163

Possible Solution
Use main context in Shard.removeGarbage()

Node version:

service@az:~$ frostfs-node --version
FrostFS Storage node
Version: v0.0.1-414-gc60029d3
GoVersion: go1.18.4

Routines list before node killing by system in attachment.

https://git.frostfs.info/TrueCloudLab/frostfs-node/src/branch/master/pkg/local_object_storage/shard/gc.go#L199 **Expected Behavior** GC stops once termination signal received. **Current Behavior** GC continue working on even we stop it. Also, it is possible that timer continues working. See tickRemover(): https://git.frostfs.info/TrueCloudLab/frostfs-node/src/branch/master/pkg/local_object_storage/shard/gc.go#L163 **Possible Solution** Use main context in Shard.removeGarbage() Node version: ``` service@az:~$ frostfs-node --version FrostFS Storage node Version: v0.0.1-414-gc60029d3 GoVersion: go1.18.4 ``` Routines list before node killing by system in attachment.

goroutine.zip

3.9 KiB