Remove --name parameter from frostfs-cli #37

New issue

Closed

opened 2023-01-31 07:24:58 +00:00 by ir0nbee · 1 comment

ir0nbee commented

2023-01-31 07:24:58 +00:00

(Migrated from github.com)

Problem

The --name parameter implies setting a name for created container. However, this does not happen since the procedure was changed and requires setting special attributes with --attributes parameter. Thus the --name parameter and its description in command line help became misleading.

Solution

Remove the --name parameter from command line.
Improve the documentation and make the information on setting container's name more accessible.

## Problem The `--name` parameter implies setting a name for created container. However, this does not happen since the procedure was changed and requires setting special attributes with `--attributes` parameter. Thus the `--name` parameter and its description in command line help became misleading. ## Solution 1) Remove the `--name` parameter from command line. 2) Improve the documentation and make the information on setting container's name more accessible.

realloc commented

2023-01-31 11:32:19 +00:00

(Migrated from github.com)

The attribute set by --name is Name, a non-unique human-friendly string.

Later we added NNS support, so special attributes __NEOFS__NAME and __NEOFS__ZONE should be set to register a container under a unique name in NNS.

I'd suggest adding a new argument, like --nns-name that would parse argument string and set one or both well-known attributes for NNS.

The attribute set by `--name` is [Name](https://github.com/TrueCloudLab/frostfs-api/blob/master/container/types.proto#L58), a non-unique human-friendly string. Later we added NNS support, so special attributes [__NEOFS__NAME](https://github.com/TrueCloudLab/frostfs-api/blob/master/container/types.proto#L43) and [__NEOFS__ZONE](https://github.com/TrueCloudLab/frostfs-api/blob/master/container/types.proto#L46) should be set to register a container under a unique name in NNS. I'd suggest adding a new argument, like `--nns-name` that would parse argument string and set one or both well-known attributes for NNS.

👍 1