Add metrics for morph caches #371
Labels
No Label
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
No Milestone
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: TrueCloudLab/frostfs-node#371
Loading…
Reference in New Issue
There is no content yet.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?
We cache many things that are taken from the blockchain.
@fyrchik suggested to add metrics for these caches trying to somehow generelize cache metric interface.
I suppose this would look like that:
and each cache struct must have embedded
CacheMetrics
implementation, like that:This also can be composited within WriteCacheMetrics
But this barely can be used for MorphClientCache, because its
cache
cannot explicitly implementCacheMetrics
-cache
is composed from three different caches and without refactoring the implementation will be like this anyway.So, I suggest to introduce generalized
CacheMetrics
interface in the next issue and use it forttlNetCache
,lruNetmapSource
andwriteCacheMetrics
and to keep metrics implementation formorphClientCache
like in the PRThe issue #451 for frostfs-node caches