TrueCloudLab
/
frostfs-node
18
1
Fork 20
Code Issues 88 Pull Requests 8 Actions Releases Activity

Drop redundant writecache metrics #395

Merged
fyrchik merged 1 commits from dstepanov-yadro/frostfs-node:fix/drop_duplicate_metrics into master 2023-05-26 13:39:39 +00:00
Conversation 0 Commits 1 Files Changed 2
dstepanov-yadro commented 2023-05-25 14:49:37 +00:00
Collaborator

HistogramVec already has labeled counter by default: https://prometheus.io/docs/practices/histograms/#count-and-sum-of-observations
So req_counter metrics are redundant.
Thx to @ale64bit

image

HistogramVec already has labeled counter by default: https://prometheus.io/docs/practices/histograms/#count-and-sum-of-observations So req_counter metrics are redundant. Thx to @ale64bit ![image](/attachments/da8c00ad-b56d-4b09-a4e4-c3b69ee8b6d4)
image.png
205 KiB
dstepanov-yadro force-pushed fix/drop_duplicate_metrics from 2a0f9096a8 to 1a556b29cc 2023-05-25 14:50:40 +00:00 Compare
dstepanov-yadro requested review from storage-core-committers 2023-05-25 14:51:30 +00:00
dstepanov-yadro requested review from storage-core-developers 2023-05-25 14:51:30 +00:00
fyrchik approved these changes 2023-05-26 09:07:07 +00:00
acid-ant approved these changes 2023-05-26 11:14:14 +00:00
fyrchik merged commit 271a56c2ab into master 2023-05-26 13:39:39 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
fyrchik
acid-ant
TrueCloudLab/storage-core-developers
Labels
Clear labels   
P0

Highest   
P1

High   
P2

Medium   
P3

Low   
badger

Badger DB related issues   
frostfs-adm
   
frostfs-cli
   
frostfs-ir
   
frostfs-lens
   
frostfs-node
   
good first issue

Good for newcomers   
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff   
blocked

The issue or PR is blocked by something   
bug

Something is not working   
config

Configuration format update or breaking change   
discussion

Talking about something in order to reach a decision or to exchange ideas   
documentation

Documentation related   
duplicate

This issue or pull request already exists   
enhancement

New feature   
go

Language features adoption   
help wanted

Extra attention is needed   
internal
   
invalid

Something is wrong   
kludge

This is a kludge and we know it   
observability

Related to metrics, tracing and logs   
perfomance

Perfomance related   
question

More information is needed   
refactoring

Refactoring   
wontfix

This won't be fixed
No Label
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#395
There is no content yet.
Delete Branch "dstepanov-yadro/frostfs-node:fix/drop_duplicate_metrics"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?