TrueCloudLab
/
frostfs-node
18
1
Fork 20
Code Issues 88 Pull Requests 8 Actions Releases Activity

[#197] object: Make Delete method return correct status #433

Merged
fyrchik merged 1 commits from aarifullin/frostfs-node:fix/197-correct_delete_status into master 2023-06-30 12:58:58 +00:00
Conversation 0 Commits 1 Files Changed 1
aarifullin commented 2023-06-07 10:10:12 +00:00
Collaborator

Signed-off-by: Airat Arifullin a.arifullin@yadro.com

Signed-off-by: Airat Arifullin a.arifullin@yadro.com
aarifullin added the
enhancement
frostfs-node
 labels 2023-06-07 10:10:12 +00:00
aarifullin requested review from storage-core-committers 2023-06-07 10:10:35 +00:00
aarifullin requested review from storage-core-developers 2023-06-07 10:10:36 +00:00
aarifullin force-pushed fix/197-correct_delete_status from 827789148b to bca9e93a08 2023-06-07 10:52:29 +00:00 Compare
dstepanov-yadro reviewed 2023-06-07 14:23:15 +00:00
pkg/services/object/delete/exec.go
@ -88,3 +90,3 @@
zap.String("error", err.Error()),
)
case err == nil:
case err == nil, apiclient.IsErrObjectAlreadyRemoved(err):
dstepanov-yadro commented 2023-06-07 14:23:15 +00:00
Collaborator

Why deleting already marked for deletion object is success?
Marked for deletion object are the same as non existing objects i think.

Why deleting already marked for deletion object is success? Marked for deletion object are the same as non existing objects i think.
aarifullin commented 2023-06-08 14:59:02 +00:00
Poster
Collaborator

Please, check the issue :)

Briefly: because Delete should return only specified statutes

Please, check the issue :) Briefly: because `Delete` should return only [specified](https://git.frostfs.info/TrueCloudLab/frostfs-api/src/commit/fc393d4605e7e4c5545e882ef20d5dc171e25ce8/object/service.proto#L99-L109) statutes
dstepanov-yadro commented 2023-06-09 14:54:27 +00:00
Collaborator

Ok, but then we can fix case delete of non-existing object, because now

frostfs-cli object delete --cid <cid> --oid <some non existing object id>

returns

failed to get raw object header: read object header via client: status: code = 2049 message = object not found

Ok, but then we can fix case `delete of non-existing object`, because now `frostfs-cli object delete --cid <cid> --oid <some non existing object id>` returns `failed to get raw object header: read object header via client: status: code = 2049 message = object not found`
fyrchik commented 2023-06-13 07:22:51 +00:00
Owner

It is tricky I believe we should change API too: if we had not found an object, but it exists, we should not return OK. cc @alexvanin @realloc

It is tricky I believe we should change API too: if we had not found an object, but it exists, we should not return OK. cc @alexvanin @realloc
aarifullin commented 2023-06-13 08:29:15 +00:00
Poster
Collaborator

@dstepanov-yadro

Oh, really. I didn't know that but you're right - I checked on my own using CLI and api methods within unittest.

It seems it's easier to extend Delete specification (as @fyrchik suggested above) with two statuses and avoid tricks like in my PR

@dstepanov-yadro Oh, really. I didn't know that but you're right - I checked on my own using CLI and api methods within [unittest](https://git.frostfs.info/TrueCloudLab/frostfs-node/issues/197#issuecomment-11619). It seems it's easier to extend `Delete` specification (as @fyrchik suggested above) with two statuses and avoid tricks like in my PR
aarifullin commented 2023-06-14 08:30:57 +00:00
Poster
Collaborator

cc @alexvanin

cc @alexvanin
👍 1
aarifullin commented 2023-06-27 09:06:41 +00:00
Poster
Collaborator

So, we decided OBJECT_ALREADY_REMOVED cannot be returned by this function but have not decided yet should it return OBJECT_NOT_FOUND instead. I'd keep this PR like that - return success in the case of OBJECT_ALREADY_REMOVED error

So, we decided `OBJECT_ALREADY_REMOVED` cannot be returned by this function but have not decided yet should it return `OBJECT_NOT_FOUND` instead. I'd keep this PR like that - return success in the case of `OBJECT_ALREADY_REMOVED` error
aarifullin changed title from [#197] object: Make Delete method return correct status to WIP: [#197] object: Make Delete method return correct status 2023-06-20 09:10:43 +00:00
aarifullin changed title from WIP: [#197] object: Make Delete method return correct status to [#197] object: Make Delete method return correct status 2023-06-27 09:05:42 +00:00
dstepanov-yadro approved these changes 2023-06-30 07:19:45 +00:00
fyrchik merged commit f437ab8f15 into master 2023-06-30 12:58:58 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dstepanov-yadro
Labels
Clear labels   
P0

Highest   
P1

High   
P2

Medium   
P3

Low   
badger

Badger DB related issues   
frostfs-adm
   
frostfs-cli
   
frostfs-ir
   
frostfs-lens
   
frostfs-node
   
good first issue

Good for newcomers   
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff   
blocked

The issue or PR is blocked by something   
bug

Something is not working   
config

Configuration format update or breaking change   
discussion

Talking about something in order to reach a decision or to exchange ideas   
documentation

Documentation related   
duplicate

This issue or pull request already exists   
enhancement

New feature   
go

Language features adoption   
help wanted

Extra attention is needed   
internal
   
invalid

Something is wrong   
kludge

This is a kludge and we know it   
observability

Related to metrics, tracing and logs   
perfomance

Perfomance related   
question

More information is needed   
refactoring

Refactoring   
wontfix

This won't be fixed
No Label
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#433
There is no content yet.
Delete Branch "aarifullin/frostfs-node:fix/197-correct_delete_status"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?