Use labels for method duration counters #435

Closed
opened 2023-06-07 15:17:41 +00:00 by dstepanov-yadro · 0 comments

For example writecache method duration metrics are defined as separate metrics for get, put and delete. I think we can use one metric with method label to pass Get, Put or Delete as label value.

Also need to check and fix other metrics.

Additional context

See https://prometheus.io/docs/practices/naming/#labels

## Is your feature request related to a problem? Please describe. For example writecache method duration metrics are defined as separate metrics for `get`, `put` and `delete`. I think we can use one metric with `method` label to pass `Get`, `Put` or `Delete` as label value. Also need to check and fix other metrics. ## Additional context See https://prometheus.io/docs/practices/naming/#labels
dstepanov-yadro added the
discussion
triage
observability
labels 2023-06-07 15:17:41 +00:00
dstepanov-yadro self-assigned this 2023-06-13 10:14:29 +00:00
fyrchik added this to the v0.37.0 milestone 2023-06-14 13:19:15 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#435
No description provided.