grpc: Increase message limits #470
No reviewers
Labels
No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
No milestone
No project
No assignees
4 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: TrueCloudLab/frostfs-node#470
Loading…
Reference in a new issue
No description provided.
Delete branch "dstepanov-yadro/frostfs-node:fix/grpc_message_size"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
For send message limit set to 2GiB, but there are custom GET/GET RANGE limiters.
For receive message limit set to 256 MiB, but actual chunk size will be managed by client.
See #77
Signed-off-by: Dmitrii Stepanov d.stepanov@yadro.com
aa80989b01
toc12dff7708
@ -22,3 +24,3 @@
grpcconfig.IterateEndpoints(c.appCfg, func(sc *grpcconfig.Config) {
serverOpts := []grpc.ServerOption{
grpc.MaxSendMsgSize(maxMsgSize),
grpc.MaxRecvMsgSize(maxRecvMsgSize),
Why not to move it in config file?
If we transfer this parameter to the configuration file, then we can get a situation where different nodes have different values set. This will lead to problems with requests.
We will face this error (if it will be) anyway because it is impossible to upgrade all nodes at once, rolling upgrade is a usual case for us.
Well, you are right.
We can prevent invalid configuration, but we can't prevent rolling upgrade.
We have increased message size, so no problems should appear when talking
old -> new
node.For
new -> old
we still use defaultchunkSize
.c12dff7708
to53e54aa2c9
53e54aa2c9
to0c5b025788