TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 101 Pull requests 4 Projects Releases 1 Activity Actions

grpc: Increase message limits #470

Merged
fyrchik merged 1 commit from dstepanov-yadro/frostfs-node:fix/grpc_message_size into master 2023-06-30 13:52:05 +00:00
Conversation 0 Commits 1 Files changed 1 +3 -1
dstepanov-yadro commented 2023-06-26 15:33:23 +00:00
Member
Copy link

For send message limit set to 2GiB, but there are custom GET/GET RANGE limiters.
For receive message limit set to 256 MiB, but actual chunk size will be managed by client.

See #77

Signed-off-by: Dmitrii Stepanov d.stepanov@yadro.com

For send message limit set to 2GiB, but there are custom GET/GET RANGE limiters. For receive message limit set to 256 MiB, but actual chunk size will be managed by client. See https://git.frostfs.info/TrueCloudLab/frostfs-node/issues/77 Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
dstepanov-yadro requested review from storage-core-committers 2023-06-26 15:33:33 +00:00
dstepanov-yadro requested review from storage-core-developers 2023-06-26 15:33:33 +00:00
dstepanov-yadro force-pushed fix/grpc_message_size from aa80989b01 to c12dff7708 2023-06-26 15:34:18 +00:00 Compare
acid-ant reviewed 2023-06-26 18:36:21 +00:00
cmd/frostfs-node/grpc.go Outdated
@ -22,3 +24,3 @@
grpcconfig.IterateEndpoints(c.appCfg, func(sc *grpcconfig.Config) {
serverOpts := []grpc.ServerOption{
grpc.MaxSendMsgSize(maxMsgSize),
grpc.MaxRecvMsgSize(maxRecvMsgSize),
acid-ant commented 2023-06-26 18:36:21 +00:00
Member
Copy link

Why not to move it in config file?

Why not to move it in config file?
dstepanov-yadro commented 2023-06-28 06:08:33 +00:00
Author
Member
Copy link

If we transfer this parameter to the configuration file, then we can get a situation where different nodes have different values set. This will lead to problems with requests.

If we transfer this parameter to the configuration file, then we can get a situation where different nodes have different values set. This will lead to problems with requests.
acid-ant commented 2023-06-28 06:53:34 +00:00
Member
Copy link

We will face this error (if it will be) anyway because it is impossible to upgrade all nodes at once, rolling upgrade is a usual case for us.

We will face this error (if it will be) anyway because it is impossible to upgrade all nodes at once, rolling upgrade is a usual case for us.
dstepanov-yadro commented 2023-06-28 12:47:49 +00:00
Author
Member
Copy link

Well, you are right.
We can prevent invalid configuration, but we can't prevent rolling upgrade.

Well, you are right. We can prevent invalid configuration, but we can't prevent rolling upgrade.
fyrchik commented 2023-06-28 12:48:33 +00:00
Owner
Copy link

We have increased message size, so no problems should appear when talking old -> new node.
For new -> old we still use default chunkSize.

We have _increased_ message size, so no problems should appear when talking `old -> new` node. For `new -> old` we still use default `chunkSize`.
aarifullin approved these changes 2023-06-29 09:07:58 +00:00
dstepanov-yadro force-pushed fix/grpc_message_size from c12dff7708 to 53e54aa2c9 2023-06-30 08:38:07 +00:00 Compare
fyrchik approved these changes 2023-06-30 12:58:17 +00:00
dstepanov-yadro force-pushed fix/grpc_message_size from 53e54aa2c9 to 0c5b025788 2023-06-30 13:32:42 +00:00 Compare
fyrchik merged commit 0c5b025788 into master 2023-06-30 13:52:05 +00:00
fyrchik referenced this pull request from a commit 2023-06-30 13:52:06 +00:00
[#470] grpc: Increase message limits
acid-ant approved these changes 2023-07-01 13:30:19 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
aarifullin
fyrchik
acid-ant
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#470
No description provided.
Delete branch "dstepanov-yadro/frostfs-node:fix/grpc_message_size"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?