node: Fix non-informative message when parse node attributes #475

acid-ant · 2023-06-27T11:32:01Z

acid-ant commented

2023-06-27 11:32:01 +00:00

Close #455

Signed-off-by: Anton Nikiforov an.nikiforov@yadro.com

Close #455 Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>

acid-ant requested review from storage-core-committers 2023-06-27 11:33:59 +00:00

acid-ant requested review from storage-core-developers 2023-06-27 11:33:59 +00:00

dstepanov-yadro approved these changes 2023-06-28 06:26:48 +00:00

fyrchik reviewed 2023-06-28 07:31:06 +00:00

pkg/util/attributes/parser.go Outdated

					
				@ -37,3 +36,3 @@

						if k == "" {

							return errors.New("empty key")

							return fmt.Errorf("unable to parse key of the node attribute from string '%s'", attrs[i])

fyrchik commented

2023-06-28 07:31:06 +00:00

To me empty key and empty value are OK, they just need a little more context (that these are key/value from a section node.attributes

To me `empty key` and `empty value` are OK, they just need a little more context (that these are key/value from a section `node.attributes`

acid-ant commented

2023-06-28 07:45:50 +00:00

Updated.

fyrchik marked this conversation as resolved

fyrchik reviewed 2023-06-28 07:31:38 +00:00

pkg/util/attributes/parser.go Outdated

					
				@ -22,3 +21,3 @@

						k, v, found := strings.Cut(line, keyValueSeparator)

						if !found {

							return errors.New("missing attribute key and/or value")

							return fmt.Errorf("wrong format for attribute: '%s'", attrs[i])