TrueCloudLab
/
frostfs-node
19
1
Fork 20
Code Issues 93 Pull Requests 9 Actions Releases Activity

.forgejo: add build/test workflows #478

Merged
fyrchik merged 3 commits from fyrchik/frostfs-node:add-workflows into master 2023-06-28 15:01:51 +00:00
Conversation 1 Commits 3 Files Changed 4
fyrchik commented 2023-06-28 08:11:39 +00:00
Owner
There is no content yet.
fyrchik force-pushed add-workflows from f7e016729e to 8a02f4c35a 2023-06-28 08:13:40 +00:00 Compare
fyrchik force-pushed add-workflows from f1cb50c37b to abe50299a8 2023-06-28 10:17:48 +00:00 Compare
fyrchik force-pushed add-workflows from abe50299a8 to 0ab3e87491 2023-06-28 10:18:15 +00:00 Compare
fyrchik requested review from storage-core-committers 2023-06-28 10:19:58 +00:00
fyrchik requested review from storage-core-developers 2023-06-28 10:19:58 +00:00
aarifullin approved these changes 2023-06-28 10:48:34 +00:00
acid-ant approved these changes 2023-06-28 10:49:52 +00:00
fyrchik force-pushed add-workflows from 0ab3e87491 to fa3f354b4c 2023-06-28 11:11:43 +00:00 Compare
fyrchik force-pushed add-workflows from fa3f354b4c to 8ace8786ed 2023-06-28 11:12:23 +00:00 Compare
acid-ant approved these changes 2023-06-28 11:16:04 +00:00
dstepanov-yadro approved these changes 2023-06-28 11:23:48 +00:00
fyrchik force-pushed add-workflows from 8ace8786ed to 7085b7952e 2023-06-28 12:04:40 +00:00 Compare
fyrchik reviewed 2023-06-28 12:06:11 +00:00
pkg/services/tree/signature.go Outdated
@ -130,3 +101,1 @@
return eACLErr(eaclOp, errBearerWrongOwner)
}
tb = bt.EACLTable()
if tableFromBearer && !bt.Impersonate() {
fyrchik commented 2023-06-28 12:06:11 +00:00
Poster
Owner

Please, pay extra attention here.

Please, pay extra attention here.
fyrchik requested review from alexvanin 2023-06-28 12:08:50 +00:00
fyrchik force-pushed add-workflows from 9ebb65ed2e to 80a05f6b33 2023-06-28 12:43:43 +00:00 Compare
fyrchik commented 2023-06-28 12:45:53 +00:00
Poster
Owner

There are problems with staticcheck, see #482

There are problems with staticcheck, see https://git.frostfs.info/TrueCloudLab/frostfs-node/issues/482
fyrchik merged commit d0ab552a90 into master 2023-06-28 15:01:51 +00:00
fyrchik deleted branch add-workflows 2023-06-28 15:01:53 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
aarifullin
acid-ant
dstepanov-yadro
alexvanin
Labels
Clear labels   
P0

Highest   
P1

High   
P2

Medium   
P3

Low   
badger

Badger DB related issues   
frostfs-adm
   
frostfs-cli
   
frostfs-ir
   
frostfs-lens
   
frostfs-node
   
good first issue

Good for newcomers   
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff   
blocked

The issue or PR is blocked by something   
bug

Something is not working   
config

Configuration format update or breaking change   
discussion

Talking about something in order to reach a decision or to exchange ideas   
documentation

Documentation related   
duplicate

This issue or pull request already exists   
enhancement

New feature   
go

Language features adoption   
help wanted

Extra attention is needed   
internal
   
invalid

Something is wrong   
kludge

This is a kludge and we know it   
observability

Related to metrics, tracing and logs   
perfomance

Perfomance related   
question

More information is needed   
refactoring

Refactoring   
wontfix

This won't be fixed
No Label
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#478
There is no content yet.
Delete Branch "fyrchik/frostfs-node:add-workflows"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?