[#521] Add netmap load command to policy playground #522

ale64bit · 2023-07-14T08:16:23Z

ale64bit commented

2023-07-14 08:16:23 +00:00

Adds a load command to load an external netmap from a json file:

> load /home/godzilla/my/netmap.json

The structure is trivial:

{
	"nodeID": {
		"attributeName": "attributeValue",
		(...)
	},
	(...)
}

For example:

{
	"01": {
		"Color": "Red",
		"Shape": "Circle"
	},
	"02": {
		"Color": "Blue",
		"Location": "Saint Petersburg",
		"Shape": "Circle"
	}
}

This makes it easy to load custom netmaps and modify the existing one and adds support for attribute names containing space. Note that the load command discards any existing netmap info.

Signed-off-by: Alejandro Lopez a.lopez@yadro.com

Closes #521

Adds a `load` command to load an external netmap from a json file: ```sh > load /home/godzilla/my/netmap.json ``` The structure is trivial: ```json { "nodeID": { "attributeName": "attributeValue", (...) }, (...) } ``` For example: ```json { "01": { "Color": "Red", "Shape": "Circle" }, "02": { "Color": "Blue", "Location": "Saint Petersburg", "Shape": "Circle" } } ``` This makes it easy to load custom netmaps and modify the existing one and adds support for attribute names containing space. Note that the `load` command discards any existing netmap info. Signed-off-by: Alejandro Lopez <a.lopez@yadro.com> Closes #521

requested reviews from d.zayakin, storage-core-committers, storage-core-developers

2023-07-14 08:16:59 +00:00

dstepanov-yadro approved these changes 2023-07-14 13:48:09 +00:00

fyrchik requested changes 2023-07-15 10:09:48 +00:00

cmd/frostfs-cli/modules/container/policy_playground.go Outdated

					
				@ -51,6 +52,7 @@ func (repl *policyPlaygroundREPL) handleAdd(args []string) error {

					if len(args) == 0 {

						return fmt.Errorf("too few arguments for command 'add': got %d, want >0", len(args))

					}

fyrchik commented

2023-07-15 10:08:03 +00:00

unrelated to the commit

ale64bit commented

2023-07-17 07:25:37 +00:00

done

fyrchik marked this conversation as resolved

cmd/frostfs-cli/modules/container/policy_playground.go Outdated

					
				@ -72,0 +83,4 @@

						return fmt.Errorf("reading netmap file %q: %v", args[0], err)

					}

					if err := json.Unmarshal(b, &jsonNetmap); err != nil {

fyrchik commented

2023-07-15 10:09:46 +00:00

Why did you decide to stay on JSON? I mean it is good, but what about supporting YAML too?

ale64bit commented

2023-07-17 07:26:52 +00:00

mmm, I guess I didn't think too much of it. JSON was simple enough for this particular use-case.

Maybe let's think about supporting YAML later, if someone actually asks for it.

mmm, I guess I didn't think too much of it. JSON was simple enough for this particular use-case. Maybe let's think about supporting YAML later, if someone actually asks for it.

👍 1

fyrchik marked this conversation as resolved

cmd/frostfs-cli/modules/container/policy_playground.go Outdated

					
				@ -132,7 +168,10 @@ func (repl *policyPlaygroundREPL) run() error {

					cmdHandlers := map[string]func([]string) error{

						"ls":     repl.handleLs,

						"list":   repl.handleLs,