Do not bootstrap if node is online candidate #525

dstepanov-yadro · 2023-07-14T13:24:34Z

dstepanov-yadro commented

2023-07-14 13:24:34 +00:00

Closes #516

requested reviews from storage-core-committers, storage-core-developers

2023-07-14 13:41:36 +00:00

fyrchik approved these changes 2023-07-15 09:48:57 +00:00

cmd/frostfs-node/netmap.go Outdated

					
				@ -292,2 +296,4 @@

				}

				func (c *cfg) isOnlineCandidate() bool {

					candidates, err := c.cfgNetmap.wrapper.GetCandidates()

fyrchik commented

2023-07-15 09:47:22 +00:00

Would it be easy to avoid making the second query (IsMaintenance already does this)?

Would it be easy to avoid making the second query (`IsMaintenance` already does this)?

dstepanov-yadro commented

2023-07-17 07:28:39 +00:00

fixed

fyrchik marked this conversation as resolved

internal/logs/logs.go Outdated

					
				@ -493,4 +493,6 @@ const (

					ShardDeleteCantDeleteFromWriteCache                                     = "can't delete object from write cache"

					FrostFSNodeNodeIsUnderMaintenanceSkipInitialBootstrap                   = "the node is under maintenance, skip initial bootstrap"

					EngineCouldNotChangeShardModeToDisabled                                 = "could not change shard mode to disabled"

					NetmapFailedToGetCandidateListAssumeNotInList                           = "failed to get candidate list, assume that current node is not in candidate list"