TrueCloudLab/frostfs-node

Assume API support status codes #533

New issue

Closed

opened 2023-07-20 08:09:11 +00:00 by fyrchik · 1 comment

fyrchik commented

2023-07-20 08:09:11 +00:00

Owner

During old NeoFS times we had to support both no-status and with-status API versions. Given that we already had some breaking changes (#248, #249) and that we also don't have any public networks currently, let's remove corresponding code from here

s.statusSupported = isStatusSupported(req.(RequestMessage)) // panic is OK here for now

cc @alexvanin @realloc

During old NeoFS times we had to support both no-status and with-status API versions. Given that we already had some breaking changes (#248, #249) and that we also don't have any public networks currently, let's remove corresponding code from here https://git.frostfs.info/TrueCloudLab/frostfs-node/src/commit/94df541426e0433653175b0f9c1f1e97da68ec70/pkg/services/util/sign.go#L66 cc @alexvanin @realloc

fyrchik added the

labels 2023-07-20 08:09:11 +00:00

fyrchik referenced this issue

2023-07-20 08:11:09 +00:00

Simplify services (part 4) #534

fyrchik added this to the v0.37.0 milestone 2023-07-20 08:37:00 +00:00

alexvanin commented

2023-07-20 13:21:20 +00:00

Owner

Agree.

Agree.

fyrchik referenced this issue

2023-07-21 15:35:29 +00:00

Simplify services (part 4) #534

fyrchik self-assigned this 2023-07-26 12:43:04 +00:00

fyrchik referenced this issue from a pull request that will close it,

2023-07-27 16:52:28 +00:00

Assume API supports status codes #547

fyrchik referenced this issue from a commit

2023-07-31 15:35:18 +00:00

[#533] services: Assume API supports status codes

fyrchik closed this issue

2023-07-31 15:35:19 +00:00

Sign in to join this conversation.

No labels

good first issue

No milestone

No project

No assignees

2 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#533

No description provided.