[#53] Fix dirty in version #54

Merged

Alexpast1423 merged 1 commit from master into master

2023-07-26 21:07:56 +00:00

Alexpast1423 commented

2023-02-13 15:01:54 +00:00

(Migrated from github.com)

Now after build debian package, we see "dirty" suffix in version, example:

neofs-node --version
NeoFS Storage node
Version: v0.35.0-43-g3209d746-dirty
GoVersion: go1.18.4

It's happens because make debpackage download all dependencies in work directory, and after download git directory have uncommited changes. All changes are placed in debian folder and i'm solve this problem after add this files in .gitignore

Signed-off-by: Aleksey Pastukhov a.pastukhov@yadro.com

Now after build debian package, we see "dirty" suffix in version, example: ``` neofs-node --version NeoFS Storage node Version: v0.35.0-43-g3209d746-dirty GoVersion: go1.18.4 ``` It's happens because ```make debpackage``` download all dependencies in work directory, and after download git directory have uncommited changes. All changes are placed in debian folder and i'm solve this problem after add this files in .gitignore Signed-off-by: Aleksey Pastukhov <a.pastukhov@yadro.com>

carpawell (Migrated from github.com) reviewed 2023-02-13 15:01:54 +00:00

acid-ant (Migrated from github.com) reviewed 2023-02-13 15:01:54 +00:00

DmitryZabolotsky (Migrated from github.com) reviewed 2023-02-13 15:01:54 +00:00

fyrchik (Migrated from github.com) reviewed 2023-02-14 06:52:26 +00:00

.gitignore

fyrchik (Migrated from github.com) commented

2023-02-14 06:52:25 +00:00

-dirty suffix is appended only if files in the working tree (committed or staged) are altered. None of these patterns is in tree. Why does it solve the problem?

`-dirty` suffix is appended only if files in the working tree (committed or staged) are altered. None of these patterns is in tree. Why does it solve the problem?

Alexpast1423 (Migrated from github.com) reviewed 2023-02-14 07:41:02 +00:00

.gitignore

Alexpast1423 (Migrated from github.com) commented

2023-02-14 07:41:01 +00:00

deb package, when building, download a dependencies and create some files in worktree, after build package i'm see next:

git status
On branch master
Your branch is up to date with 'origin/master'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
	modified:   debian/changelog

Untracked files:
  (use "git add <file>..." to include in what will be committed)
	debian/debhelper-build-stamp
	debian/files
	debian/frostfs-adm.bash-completion
	debian/frostfs-cli.bash-completion
	debian/frostfs-cli.debhelper.log
	debian/frostfs-cli.substvars
	debian/frostfs-cli/
	debian/frostfs-ir.debhelper.log
	debian/frostfs-ir.substvars
	debian/frostfs-ir/
	debian/frostfs-storage.debhelper.log
	debian/frostfs-storage.postrm.debhelper
	debian/frostfs-storage.substvars
	debian/frostfs-storage/
	man/

this files are make version dirty, because they always created on build package.

On this mask created:
debian/debhelper-build-stamp debian/frostfs-cli.debhelper.log debian/frostfs-ir.debhelper.log debian/frostfs-storage.debhelper.log debian/frostfs-storage.postrm.debhelper

on you gitignore was a **/.debhelper but this not working ....

deb package, when building, download a dependencies and create some files in worktree, after build package i'm see next: ``` git status On branch master Your branch is up to date with 'origin/master'. Changes not staged for commit: (use "git add <file>..." to update what will be committed) (use "git restore <file>..." to discard changes in working directory) modified: debian/changelog Untracked files: (use "git add <file>..." to include in what will be committed) debian/debhelper-build-stamp debian/files debian/frostfs-adm.bash-completion debian/frostfs-cli.bash-completion debian/frostfs-cli.debhelper.log debian/frostfs-cli.substvars debian/frostfs-cli/ debian/frostfs-ir.debhelper.log debian/frostfs-ir.substvars debian/frostfs-ir/ debian/frostfs-storage.debhelper.log debian/frostfs-storage.postrm.debhelper debian/frostfs-storage.substvars debian/frostfs-storage/ man/ ``` this files are make version dirty, because they always created on build package. On this mask created: `` debian/debhelper-build-stamp debian/frostfs-cli.debhelper.log debian/frostfs-ir.debhelper.log debian/frostfs-storage.debhelper.log debian/frostfs-storage.postrm.debhelper `` on you gitignore was a ``**/.debhelper`` but this not working ....