Bug in `SizeInBytesSafe` function #542

New Issue

Closed

opened 2023-07-26 14:00:34 +00:00 by dstepanov-yadro · 0 comments

dstepanov-yadro commented

2023-07-26 14:00:34 +00:00

Collaborator

There is a bug with strings like Xb or XB, where X - one digit

Steps to Reproduce (for bugs)

File cmd/frostfs-node/config/test/config.yaml, add

sizes:
	...
    size_one_byte: 1b

File cmd/frostfs-node/config/test/config.json, add

  "sizes": {
...
    "size_one_byte": "1b"
},

File cmd/frostfs-node/config/cast_test.go add test case:

require.EqualValues(t, 1, config.SizeInBytesSafe(c, "size_one_byte"))

Context

SizeInBytesSafe from cmd/frostfs-node/config/cast.go

There is a bug with strings like `Xb` or `XB`, where X - one digit ## Steps to Reproduce (for bugs) 1. File `cmd/frostfs-node/config/test/config.yaml`, add ``` sizes: ... size_one_byte: 1b ``` 2. File `cmd/frostfs-node/config/test/config.json`, add ``` "sizes": { ... "size_one_byte": "1b" }, ``` 3. File `cmd/frostfs-node/config/cast_test.go` add test case: ``` require.EqualValues(t, 1, config.SizeInBytesSafe(c, "size_one_byte")) ``` ## Context `SizeInBytesSafe` from cmd/frostfs-node/config/cast.go