TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 105 Pull requests 11 Projects Releases 2 Activity Actions

eacl: Fix bug with casting to ObjectAccessDenied error #553

Merged
fyrchik merged 1 commit from aarifullin/frostfs-node:fix/eacl_errors into master 2023-08-02 07:22:49 +00:00
Conversation 0 Commits 1 Files changed 2 +32 -2
aarifullin commented 2023-08-01 13:22:41 +00:00
Member
Copy link

Signed-off-by: Airat Arifullin a.arifullin@yadro.com

Signed-off-by: Airat Arifullin a.arifullin@yadro.com
aarifullin added the
bug
 label 2023-08-01 13:22:41 +00:00
aarifullin changed title from [#xx] eacl: Fix bug with casting to ObjectAccessDenied error to [#553] eacl: Fix bug with casting to ObjectAccessDenied error 2023-08-01 13:22:58 +00:00
aarifullin force-pushed fix/eacl_errors from a1c279cf0c to 5519dfde4f 2023-08-01 13:23:35 +00:00 Compare
requested reviews from storage-core-committers, storage-core-developers 2023-08-01 13:23:47 +00:00
ale64bit approved these changes 2023-08-01 13:29:28 +00:00
pkg/services/object/acl/v2/errors_test.go Outdated
@ -0,0 +13,4 @@
var errAccessDenied *apistatus.ObjectAccessDenied
if !errors.As(err, &errAccessDenied) {
ale64bit commented 2023-08-01 13:29:05 +00:00
Member
Copy link

require.True(...).
Same below.

`require.True(...)`. Same below.
fyrchik commented 2023-08-01 13:34:53 +00:00
Owner
Copy link

require.ErrorsAs is also possible

`require.ErrorsAs` is also possible
aarifullin commented 2023-08-01 13:37:55 +00:00
Author
Member
Copy link

Changed to require.ErrorsAs.
To be honest I don't really like message format that require package uses for errors. That's why I initally used t.Fatalf, but I am ok with require.ErrorsAs

Changed to `require.ErrorsAs`. To be honest I don't really like message format that `require` package uses for errors. That's why I initally used `t.Fatalf`, but I am ok with `require.ErrorsAs`
realloc changed title from [#553] eacl: Fix bug with casting to ObjectAccessDenied error to eacl: Fix bug with casting to ObjectAccessDenied error 2023-08-01 13:33:04 +00:00
aarifullin force-pushed fix/eacl_errors from 5519dfde4f to 9c2c8697a5 2023-08-01 13:35:14 +00:00 Compare
aarifullin force-pushed fix/eacl_errors from 9c2c8697a5 to cae3085551 2023-08-01 13:36:11 +00:00 Compare
fyrchik approved these changes 2023-08-01 13:40:36 +00:00
pkg/services/object/acl/v2/errors_test.go Outdated
@ -0,0 +19,4 @@
func TestEACLErr(t *testing.T) {
var reqInfo RequestInfo
errAny := apistatus.ObjectNotFound{}
fyrchik commented 2023-08-01 13:40:35 +00:00
Owner
Copy link

This is not "any error", the most generic would be sth with errors.New I believe

This is not "any error", the most generic would be sth with `errors.New` I believe
aarifullin commented 2023-08-01 13:44:42 +00:00
Author
Member
Copy link

Alright. I think you are right. I needed any error to create the instance :)

UPD: fixed to errors.New

Alright. I think you are right. I needed any error to create the instance :) UPD: fixed to `errors.New`
fyrchik marked this conversation as resolved
aarifullin force-pushed fix/eacl_errors from cae3085551 to 6e69410c17 2023-08-01 13:46:51 +00:00 Compare
acid-ant approved these changes 2023-08-01 13:55:53 +00:00
fyrchik approved these changes 2023-08-01 13:56:25 +00:00
fyrchik merged commit b3695411d9 into master 2023-08-02 07:22:49 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
ale64bit
acid-ant
fyrchik
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#553
No description provided.
Delete branch "aarifullin/frostfs-node:fix/eacl_errors"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?