Fix permissions in example configs #579

New Issue

Open

opened 2023-08-08 17:28:51 +00:00 by fyrchik · 1 comment

fyrchik commented

2023-08-08 17:28:51 +00:00

Owner

According to YAML spec octal numbers should start with '0o' (see "changes in version 1.2): https://yaml.org/spec/1.2.2/ext/changes/

Viper supports 1.2 (via go-yaml.v3) but currently violates the spec because of the backwards compatibility:
f6f7691b1f/resolve.go (L233)
f6f7691b1f/resolve.go (L200)

There is not much we could do for validation (viper "just reads" the yaml, all conversions are done afterwards), but we can at least fix the example: either use 0o644 or '0644'.

This could've been such a tasty bug during some future updrade, lucky for us our deployments use string currently.

According to YAML spec octal numbers should start with '0o' (see "changes in version 1.2): https://yaml.org/spec/1.2.2/ext/changes/ Viper supports 1.2 (via go-yaml.v3) but currently violates the spec because of the backwards compatibility: https://github.com/go-yaml/yaml/blob/f6f7691b1fdeb513f56608cd2c32c51f8194bf51/resolve.go#L233 https://github.com/go-yaml/yaml/blob/f6f7691b1fdeb513f56608cd2c32c51f8194bf51/resolve.go#L200 There is not much we could do for validation (viper "just reads" the yaml, all conversions are done afterwards), but we can at least fix the example: either use `0o644` or `'0644'`. This could've been such a tasty bug during some future updrade, lucky for us our deployments use `string` currently.