Think out badger metrics and traces #583

New issue

Closed

opened 2023-08-09 10:41:58 +00:00 by fyrchik · 1 comment

fyrchik commented

2023-08-09 10:41:58 +00:00

Owner

It has something exported via the https://github.com/dgraph-io/badger/blob/main/y/metrics.go
It also has traces (see runGC function), though it creates a new context and it uses another package for this.

I suggest disabling traces and, possibly, having expvar reexported via prometheus. Note that in this case metrics presense in config-dependent and may miss from the output of ./scripts/export-metrics script -- need to think what we do here. Another option is to disable metrics.

It has something exported via the https://github.com/dgraph-io/badger/blob/main/y/metrics.go It also has traces (see `runGC` function), though it creates a new context and it uses another package for this. I suggest disabling traces and, possibly, having `expvar` reexported via prometheus. Note that in this case metrics presense in config-dependent and may miss from the output of `./scripts/export-metrics` script -- need to think what we do here. Another option is to disable metrics.