[#xx] Fix writecache benchmarks and refactor hacky NeedsCompression #586

ale64bit · 2023-08-09T12:56:08Z

ale64bit commented

2023-08-09 12:56:08 +00:00

Previously they were not accurate due to missing RawData and swallowing the error.

Signed-off-by: Alejandro Lopez a.lopez@yadro.com

Previously they were not accurate due to missing `RawData` and swallowing the error. Signed-off-by: Alejandro Lopez <a.lopez@yadro.com>

ale64bit requested review from storage-core-committers 2023-08-09 12:56:19 +00:00

ale64bit requested review from storage-core-developers 2023-08-09 12:56:21 +00:00

ale64bit force-pushed fix/wc-benchmarks from cb211f31be to 41c24d2f71

2023-08-09 12:57:11 +00:00

Compare

ale64bit force-pushed fix/wc-benchmarks from 41c24d2f71 to 66e4f76f49

2023-08-09 13:29:41 +00:00

Compare

acid-ant approved these changes 2023-08-09 13:46:36 +00:00

fyrchik approved these changes 2023-08-09 14:17:28 +00:00

pkg/local_object_storage/writecache/writecachebadger/options.go Outdated

													
				@ -36,3 +17,3 @@

					path string

					// blobstor is the main persistent storage.

					blobstor blob

					blobstor writecache.Storage

fyrchik commented

2023-08-09 14:13:08 +00:00

Storage here is related not to the writecache storage, but to the storage it flushes too
Cae we leave the name as Blobstor?

`Storage` here is related not to the writecache storage, but to the storage it flushes too Cae we leave the name as `Blobstor`?

ale64bit commented

2023-08-10 07:04:26 +00:00

Poster

discussed offline. Renamed to MainStorage.

discussed offline. Renamed to `MainStorage`.

fyrchik marked this conversation as resolved

pkg/local_object_storage/writecache/writecachebbolt/put.go Outdated

													
				@ -113,3 +113,3 @@

					}

					if c.blobstor.NeedsCompression(prm.Object) {

					if c.blobstor.Compressor().NeedsCompression(prm.Object) {

fyrchik commented

2023-08-09 14:17:26 +00:00

Maybe also make (*compression.Config) NeedsCompression() work for nil Config?
Or check for nil here, I think it is easy to forget this in blobstor, for example.

Maybe also make `(*compression.Config) NeedsCompression()` work for `nil` Config? Or check for nil here, I think it is easy to forget this in blobstor, for example.

ale64bit commented

2023-08-10 07:04:34 +00:00

Poster

done

fyrchik marked this conversation as resolved

ale64bit force-pushed fix/wc-benchmarks from 66e4f76f49 to 0143ccb2db

2023-08-10 07:03:59 +00:00

Compare

fyrchik approved these changes 2023-08-10 08:05:13 +00:00

fyrchik merged commit 8f994163ee into master

2023-08-10 08:05:20 +00:00

fyrchik referenced this issue from a commit