Fix/Do not fetch missing objects #61

carpawell · 2023-02-17T14:24:09Z

carpawell commented

2023-02-17 14:24:09 +00:00

(Migrated from github.com)

Should be discussed.

acid-ant (Migrated from github.com) reviewed 2023-02-17 14:33:59 +00:00

fyrchik (Migrated from github.com) reviewed 2023-02-20 10:52:48 +00:00

pkg/local_object_storage/shard/get.go

					
				@ -115,0 +113,4 @@

						if !mRes.Exists() {

							return nil, false, logicerr.Wrap(apistatus.ObjectNotFound{})

						}

					} else {

fyrchik (Migrated from github.com) commented

2023-02-20 10:52:30 +00:00

To we need to take s.info.Mode.NoMetabase() into account here?

To we need to take `s.info.Mode.NoMetabase()` into account here?

carpawell (Migrated from github.com) reviewed 2023-02-20 11:33:35 +00:00

pkg/local_object_storage/shard/get.go

					
				@ -115,0 +113,4 @@

						if !mRes.Exists() {

							return nil, false, logicerr.Wrap(apistatus.ObjectNotFound{})

						}

					} else {

carpawell (Migrated from github.com) commented

2023-02-20 11:33:34 +00:00

5303736acd/pkg/local_object_storage/shard/get.go (L85)

that line saves us from that if branch execution without meta

https://github.com/TrueCloudLab/frostfs-node/blob/5303736acd240809c67847c2c898f97a3e419d05/pkg/local_object_storage/shard/get.go#L85 that line saves us from that `if` branch execution without meta

fyrchik (Migrated from github.com) approved these changes 2023-02-20 11:37:57 +00:00

carpawell referenced this pull request from a commit

2023-03-22 17:36:30 +00:00

[#61] node: Do not fetch missing objects

Sign in to join this conversation.

No reviewers

fyrchik

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#61