Simplify writecache implementations #610

New issue

Open

opened 2023-08-15 07:02:02 +00:00 by ale64bit · 3 comments

ale64bit commented

2023-08-15 07:02:02 +00:00

Member

Both writecache implementations have quite high cognitive complexity in my opinion. It would be nice to simplify them (or ideally, to remove them).

ale64bit added the

enhancement

discussion

triage

labels 2023-08-15 07:02:02 +00:00

ale64bit referenced this issue

2023-08-15 07:02:17 +00:00

[#598] Fix read-after-close bug in badger writecache #604

fyrchik commented

2023-08-15 07:04:01 +00:00

Owner

Do you have any specific ideas in mind?

fyrchik referenced this issue

2023-08-15 07:25:04 +00:00

Fix writecache counters #595

fyrchik commented

2023-08-16 08:20:38 +00:00

Owner

SetMode may be a Close + Open combination. This is arguably simpler and won't hurt user operations: they all take modeMtx anyway. (thanks, @ale64bit )

The problem here is that initialization stage may be too long. For example, counters and metrics initialization. For this we may have some logic in open: before the initialization check if they are already initialized.

`SetMode` may be a `Close + Open` combination. This is arguably simpler and won't hurt user operations: they all take `modeMtx` anyway. (thanks, @ale64bit ) The problem here is that initialization stage may be too long. For example, counters and metrics initialization. For this we may have some logic in open: before the initialization check if they are already initialized.

ale64bit commented

2023-08-16 10:06:10 +00:00

Author

Member

Do you have any specific ideas in mind?

I would recommend trying to implement something very simple, not using any existing key-value and without the need to iterate over the key space continuously.

> Do you have any specific ideas in mind? I would recommend trying to implement something very simple, not using any existing key-value and without the need to iterate over the key space continuously.

ale64bit referenced this issue

2023-08-22 06:43:26 +00:00

Writecache potential consistency issues #634

fyrchik added this to the v0.38.0 milestone 2023-08-23 10:41:28 +00:00

fyrchik modified the milestone from v0.38.0 to v0.39.0

2024-02-12 06:28:24 +00:00

fyrchik modified the milestone from v0.39.0 to vNext

2024-05-14 14:12:39 +00:00