Add useStrconv linter #618
No reviewers
Labels
No Label
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
No Milestone
No Assignees
4 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: TrueCloudLab/frostfs-node#618
Loading…
Reference in New Issue
There is no content yet.
Delete Branch "achuprov/frostfs-node:nofmt"
Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?
Introduced a linter, following Uber Go Style Guide, that recommends using
strconv
overfmt
After TrueCloudLab/linters#10 is merged, please restart the tests and then merge
Add nofmt linterto Add useStrconv linterf5b5e26e44
to2cc61c78f8
@ -292,3 +293,3 @@
attribute.String("container_id", cid.EncodeToString()),
attribute.String("tree_id", treeID),
attribute.String("height", fmt.Sprintf("%d", height)),
attribute.String("height", strconv.FormatUint(height, 10)),
Unrelated to this PR:
Actually, I am wondering -- why don't we use
attribute.Int64
here?I see It should be signed by the spec
9e6a3de19c/specification/common/common.md (attributes)
-- because of this?cc @dstepanov-yadro